Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase trait test coverage #1547

Closed
bouskaJ opened this issue Jun 22, 2020 · 2 comments
Closed

Increase trait test coverage #1547

bouskaJ opened this issue Jun 22, 2020 · 2 comments
Assignees
@tadayosi
Milestone
1.4.0

Comments

@bouskaJ
Copy link
Contributor

bouskaJ commented Jun 22, 2020

We have low/no test coverage for the following traits:

github.com/apache/camel-k/pkg/trait/prometheus.go 
github.com/apache/camel-k/pkg/trait/jolokia.go 
github.com/apache/camel-k/pkg/trait/affinity.go
github.com/apache/camel-k/pkg/trait/istio.go
github.com/apache/camel-k/pkg/trait/pull_secret.go

We should add e2e tests for increasing test coverage.
@nicolaferraro nicolaferraro added this to the 1.1.0 milestone Jun 22, 2020
@nicolaferraro nicolaferraro modified the milestones: 1.1.0, 1.2.0 Jul 17, 2020
@nicolaferraro nicolaferraro modified the milestones: 1.2.0, 1.3.0 Oct 7, 2020
@tadayosi
Copy link
Member

If no one has started it yet, I can work on it.

tadayosi added a commit to tadayosi/camel-k that referenced this issue Dec 7, 2020
@tadayosi
chore(e2e): add test for Jolokia trait apache#1547
652c7e4
tadayosi added a commit to tadayosi/camel-k that referenced this issue Dec 7, 2020
@tadayosi
chore(e2e): add test for Jolokia trait apache#1547
b302115
astefanutti pushed a commit that referenced this issue Dec 7, 2020
@tadayosi @astefanutti
chore(e2e): add test for Jolokia trait #1547
1d0e9c8
tadayosi added a commit to tadayosi/camel-k that referenced this issue Dec 8, 2020
@tadayosi
chore(e2e): add test for Prometheus trait apache#1547
f77f672
tadayosi added a commit to tadayosi/camel-k that referenced this issue Dec 10, 2020
@tadayosi
chore(e2e): add test for Prometheus trait apache#1547
8956366
tadayosi added a commit that referenced this issue Dec 10, 2020
@tadayosi
chore(e2e): add test for Prometheus trait #1547
d4ba41f
tadayosi added a commit to tadayosi/camel-k that referenced this issue Dec 16, 2020
@tadayosi
chore(e2e): add test for Pull Secret trait apache#1547
f0af161
tadayosi added a commit to tadayosi/camel-k that referenced this issue Dec 16, 2020
@tadayosi
chore(e2e): add test for Pull Secret trait apache#1547
e9b4c58
astefanutti pushed a commit that referenced this issue Dec 16, 2020
@tadayosi @astefanutti
chore(e2e): add test for Pull Secret trait #1547
312c6bd
tadayosi added a commit to tadayosi/camel-k that referenced this issue Dec 17, 2020
@tadayosi
chore(e2e): add test for Affinity trait apache#1547
8785ba8
tadayosi added a commit to tadayosi/camel-k that referenced this issue Dec 17, 2020
@tadayosi
chore(e2e): add test for Affinity trait apache#1547
c8bda85
tadayosi added a commit to tadayosi/camel-k that referenced this issue Dec 17, 2020
@tadayosi
chore(e2e): add test for Affinity trait apache#1547
119f511
astefanutti pushed a commit that referenced this issue Dec 17, 2020
@tadayosi @astefanutti
chore(e2e): add test for Affinity trait #1547
8e5541e
@nicolaferraro nicolaferraro modified the milestones: 1.3.0, 1.4.0 Dec 22, 2020
@nicolaferraro nicolaferraro mentioned this issue Dec 22, 2020
Closed
tadayosi added a commit to tadayosi/camel-k that referenced this issue Jan 8, 2021
@tadayosi
chore(e2e): add test for Istio trait apache#1547
74802be
astefanutti pushed a commit that referenced this issue Jan 8, 2021
@tadayosi @astefanutti
chore(e2e): add test for Istio trait #1547
4259404
@tadayosi
Copy link
Member

tadayosi commented Jan 8, 2021

Now covered all of the listed traits. Let's close it.

@tadayosi tadayosi closed this as completed Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tadayosi tadayosi

Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

No branches or pull requests
3 participants
@tadayosi @nicolaferraro @bouskaJ