Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting parameters as modeline options #1449

Closed
nicolaferraro opened this issue May 6, 2020 · 1 comment
Closed

Support setting parameters as modeline options #1449

nicolaferraro opened this issue May 6, 2020 · 1 comment
Assignees
Milestone

Comments

@nicolaferraro
Copy link
Member

This should be the "supported" way of setting options for running files.

On an integration file:

// camel-k: dependency=camel-hl7 trait=quarkus.enabled=true

from("...")...

This way:

  • information about how to run a file are self-contained in the file
  • we don't forget about an external config file that overrides our settings
  • the semantics is well defined: it's like those options are passed to the command line together with other options that you pass

It should also work:

  • with multiple lines (each one starting with comment and "camel-k: "
  • in multiple files (e.g. linked with "--source" or via args)
@lburgazzoli
Copy link
Contributor

lburgazzoli commented May 6, 2020

@nicolaferraro once done, I would remove the kamel/run/integrations/$name support from the config file so you can still have default run parameters taken from the file but for specific integration you should use the modeline

nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue May 7, 2020
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue May 8, 2020
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue May 8, 2020
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue May 8, 2020
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue May 8, 2020
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue May 8, 2020
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue May 8, 2020
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue May 8, 2020
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue May 8, 2020
nicolaferraro added a commit that referenced this issue May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants