Skip to content

Commit

Permalink
chore(e2e): remove duplicate test in knative tests
Browse files Browse the repository at this point in the history
The two tests are identical except method names.
  • Loading branch information
tadayosi committed Jun 8, 2021
1 parent 2e3613d commit 170950b
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 29 deletions.
13 changes: 0 additions & 13 deletions e2e/knative/knative_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,19 +56,6 @@ func TestRunServiceCombo(t *testing.T) {
})
}

func TestRunChannelComboV1Alpha1(t *testing.T) {
WithNewTestNamespace(t, func(ns string) {
Expect(CreateKnativeChannelv1Alpha1(ns, "messages")()).To(Succeed())
Expect(Kamel("install", "-n", ns, "--trait-profile", "knative").Execute()).To(Succeed())
Expect(Kamel("run", "-n", ns, "files/knativech2.groovy").Execute()).To(Succeed())
Expect(Kamel("run", "-n", ns, "files/knativech1.groovy").Execute()).To(Succeed())
Eventually(IntegrationPodPhase(ns, "knativech2"), TestTimeoutLong).Should(Equal(v1.PodRunning))
Eventually(IntegrationPodPhase(ns, "knativech1"), TestTimeoutLong).Should(Equal(v1.PodRunning))
Eventually(IntegrationLogs(ns, "knativech2"), TestTimeoutMedium).Should(ContainSubstring("Received: Hello from knativech1"))
Expect(Kamel("delete", "--all", "-n", ns).Execute()).To(Succeed())
})
}

func TestRunChannelComboV1Beta1(t *testing.T) {
WithNewTestNamespace(t, func(ns string) {
Expect(CreateKnativeChannelv1Beta1(ns, "messages")()).To(Succeed())
Expand Down
16 changes: 0 additions & 16 deletions e2e/support/test_support.go
Original file line number Diff line number Diff line change
Expand Up @@ -1021,22 +1021,6 @@ func CreateKamelPod(ns string, name string, command ...string) error {
Knative
*/

func CreateKnativeChannelv1Alpha1(ns string, name string) func() error {
return func() error {
channel := messaging.InMemoryChannel{
TypeMeta: metav1.TypeMeta{
Kind: "InMemoryChannel",
APIVersion: messaging.SchemeGroupVersion.String(),
},
ObjectMeta: metav1.ObjectMeta{
Namespace: ns,
Name: name,
},
}
return TestClient().Create(TestContext, &channel)
}
}

func CreateKnativeChannelv1Beta1(ns string, name string) func() error {
return func() error {
channel := messaging.InMemoryChannel{
Expand Down

0 comments on commit 170950b

Please sign in to comment.