Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release 1.16.0 #927

Merged
merged 7 commits into from
Nov 23, 2022
Merged

Prepare release 1.16.0 #927

merged 7 commits into from
Nov 23, 2022

Conversation

oscerd
Copy link
Contributor

@oscerd oscerd commented Nov 17, 2022

Release Note

Aligning to Camel 3.19.0, Quarkus 2.14.0.Final, Quarkus Platform 2.14.0.Final and Camel-quarkus 2.14.0

All set, there is one single error in catalog. We have duplicate schemes for knative

[INFO] Running post-build script: /home/oscerd/workspace/apache-camel/camel-k-runtime/support/camel-k-maven-plugin/target/it/generate-catalog/verify.groovy
[INFO]   The post-build script did not succeed. Duplicated schemes: [knative]. Expression: (diff.size() == 0)
[INFO]           generate-catalog/pom.xml ......................... FAILED (3.0 s)

@oscerd oscerd added this to the 1.16.0 milestone Nov 17, 2022
@oscerd oscerd changed the title 1.16.0 prepare Prepare release 1.16.0 Nov 17, 2022
@oscerd
Copy link
Contributor Author

oscerd commented Nov 17, 2022

@squakez @claudio4j

Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need to remove those components originally in the runtime and now in Camel.

@oscerd
Copy link
Contributor Author

oscerd commented Nov 17, 2022

But I guess it should have been failing also on 1.15, so I'm not sure if it is coming from somewhere else. Maybe @lburgazzoli knows more

@lburgazzoli
Copy link
Contributor

But I guess it should have been failing also on 1.15, so I'm not sure if it is coming from somewhere else. Maybe @lburgazzoli knows more

The knative extension has been introduce in camel quarkus 2.14.x, that's the only thing I know.

@zbendhiba may know more

@tadayosi
Copy link
Member

As discussed at apache/camel-k#3817, there's currently an issue with native builds for Camel K due to the version of ubi-quarkus-native-image in the camel-k-runtime.

@oscerd
Copy link
Contributor Author

oscerd commented Nov 18, 2022

@squakez @lburgazzoli @zbendhiba

I removed the camel-k-knative stuff from camel-k-runtime and pointing only to camel-quarkus-knative. Locally I still have failing itests related to knative.

@squakez
Copy link
Contributor

squakez commented Nov 21, 2022

Adding @claudio4j as he did some work in Knative recently and may have some idea about the failure.

@claudio4j
Copy link
Contributor

It seems not all camel-k-knative were migrated to camel-quarkus, the impl module functionality is not there, specifically this @LoaderInterceptor("knative-source") which is failing.

@oscerd
Copy link
Contributor Author

oscerd commented Nov 22, 2022

@zbendhiba

@oscerd
Copy link
Contributor Author

oscerd commented Nov 23, 2022

It should be aligned now.

@oscerd
Copy link
Contributor Author

oscerd commented Nov 23, 2022

All green. I'm going to merge.

@oscerd oscerd merged commit 6aca02f into main Nov 23, 2022
claudio4j added a commit to claudio4j/camel-k that referenced this pull request Nov 23, 2022
squakez pushed a commit to squakez/camel-k that referenced this pull request Nov 24, 2022
claudio4j added a commit to claudio4j/camel-k that referenced this pull request Nov 25, 2022
This PR brought knative from camel-quarkus
apache/camel-k-runtime#927

There is a breaking change related to Yaml dsl, the template keywork was
renamed to routeTemplate
https://camel.apache.org/manual/camel-3x-upgrade-guide-3_19.html#_camel_yaml_dsl
claudio4j added a commit to claudio4j/camel-k that referenced this pull request Nov 25, 2022
This PR brought knative from camel-quarkus
apache/camel-k-runtime#927

There is a breaking change related to Yaml dsl, the template keywork was
renamed to routeTemplate
https://camel.apache.org/manual/camel-3x-upgrade-guide-3_19.html#_camel_yaml_dsl
@zbendhiba zbendhiba deleted the 1.16.0-prepare branch November 25, 2022 08:21
@zbendhiba
Copy link

@claudio4j yes I migrated just one part, need to migrate the rest.

oscerd pushed a commit to apache/camel-k that referenced this pull request Nov 28, 2022
This PR brought knative from camel-quarkus
apache/camel-k-runtime#927

There is a breaking change related to Yaml dsl, the template keywork was
renamed to routeTemplate
https://camel.apache.org/manual/camel-3x-upgrade-guide-3_19.html#_camel_yaml_dsl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants