-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support full yaml dsl #80 #84
Conversation
f13a676
to
253358b
Compare
camel-k-runtime-yaml/src/main/java/org/apache/camel/k/yaml/Yaml.java
Outdated
Show resolved
Hide resolved
camel-k-runtime-yaml/src/main/java/org/apache/camel/k/yaml/YamlRoutesLoader.java
Show resolved
Hide resolved
camel-k-runtime-yaml/src/main/java/org/apache/camel/k/yaml/converter/ChoiceConverter.java
Outdated
Show resolved
Hide resolved
Looks really good. Only found cosmetic issues in the comments. However I do think we should think about the naming of Really like the groovy testing stuff you do for all the EIPs. |
camel-k-runtime-yaml/src/main/java/org/apache/camel/k/yaml/model/Definitions.java
Outdated
Show resolved
Hide resolved
+1 on the converter naming, some proposals:
|
@davsclaus @valdar yeah, the things have originally started as plain jackson converters so named according but it turned out it was not possible to fully marshal/unmarshal steps using standard things. Any suggestion for a better naming is very welcome. |
ok, working on renaming things to StepParser @valdar @davsclaus do you mind doing a second review ? |
Yeah StepParser is better than Converter |
60be766
to
55a53d8
Compare
camel-k-runtime-yaml/src/main/java/org/apache/camel/k/yaml/model/Definitions.java
Show resolved
Hide resolved
55a53d8
to
b478188
Compare
camel-k-runtime-yaml/src/main/java/org/apache/camel/k/yaml/model/Definitions.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Fixes #80
This is the first iteration for an YAMLesque DSL so that you can define routes as:
The DSL can be extended by providing a "service" like file, see as example the custom step handler for knative here in the pr.
What's left:
The DSL support also a "flow style" where the inner steps for things such as
filter
orsplit
can be omitted: