Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

servlet: update catalog and bom #70

Merged
merged 1 commit into from
May 22, 2019

Conversation

lburgazzoli
Copy link
Contributor

No description provided.

@lburgazzoli lburgazzoli requested a review from valdar May 22, 2019 14:14
Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just minor stuff

public void testArtifactsEnrichment(){
CatalogProcessor processor = new CatalogProcessor_2_x();
CamelCatalog catalog = versionCamelCatalog("2.23.0");
Map<String, CamelArtifact> artifactMap = new HashMap<>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't better to test against 2.23.2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@lburgazzoli lburgazzoli merged commit 97acb1e into apache:master May 22, 2019
@lburgazzoli lburgazzoli deleted the catalot-servlet branch May 22, 2019 14:49
Copy link
Member

@valdar valdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lburgazzoli added a commit to lburgazzoli/apache-camel-k-runtime that referenced this pull request Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants