Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

knative: split producer and consumer #551

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

lburgazzoli
Copy link
Contributor

Fixes #521

Release Note

NONE

@lburgazzoli lburgazzoli marked this pull request as draft November 11, 2020 11:32
@lburgazzoli
Copy link
Contributor Author

lburgazzoli commented Nov 11, 2020

I've removed the hard dependency between the knative and the platorm-http component, however to fully take advantage of the split we need some additional work on the operator side:

  • we require the platform-http capability only when we have a consumer knative endpoint (but this mean we need to add some special handling for the knative component)
  • we add additional info to the catalog to list individual dependencies/capabilities required by the producer and or consumer, like:
camel-k-knative:
  groupId: org.apache.camel.k
  artifactId: camel-k-knative
  schemes:
  - id: knative
    http: true
    passive: false
  consumer:
    required-capabilities:
    - platform-http

@nicolaferraro what do you think ?

@nicolaferraro
Copy link
Member

I've removed the hard dependency between the knative and the platorm-http component, however to fully take advantage of the split we need some additional work on the operator side:

  • we require the platform-http capability only when we have a consumer knative endpoint (but this mean we need to add some special handling for the knative component)
  • we add additional info to the catalog to list individual dependencies/capabilities required by the producer and or consumer, like:
camel-k-knative:
  groupId: org.apache.camel.k
  artifactId: camel-k-knative
  schemes:
  - id: knative
    http: true
    passive: false
  consumer:
    required-capabilities:
    - platform-http

@nicolaferraro what do you think ?

Sounds reasonable. I've opened: apache/camel-k#1808

@lburgazzoli lburgazzoli force-pushed the github-521 branch 2 times, most recently from 9f61270 to bd13c9b Compare November 11, 2020 17:06
@lburgazzoli
Copy link
Contributor Author

lburgazzoli commented Nov 12, 2020

I've added the prodcuer and consumer entries as part of the scheme

    camel-k-knative:
      groupId: org.apache.camel.k
      artifactId: camel-k-knative
      schemes:
      - id: knative
        http: true
        passive: false
        producer:
          dependencies:
          - groupId: org.apache.camel.k
            artifactId: camel-k-knative-producer
        consumer:
          dependencies:
          - groupId: org.apache.camel.k
            artifactId: camel-k-knative-consumer

At the moment, only dependencies are added but we can revisit it to include also capabilities

@lburgazzoli lburgazzoli marked this pull request as ready for review November 12, 2020 11:13
@lburgazzoli lburgazzoli merged commit c758c1e into apache:master Nov 12, 2020
@lburgazzoli lburgazzoli deleted the github-521 branch November 12, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

knative: split producer and consumer transport to avoid requiring platorm-http also for the producer
3 participants