Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Quarkus as runtime #359 #543

Merged
merged 27 commits into from
Nov 9, 2020
Merged

Conversation

lburgazzoli
Copy link
Contributor

Release Note

NONE

@lburgazzoli lburgazzoli force-pushed the github-359 branch 12 times, most recently from 2fa1ee2 to e91ecdd Compare November 5, 2020 15:55
@lburgazzoli lburgazzoli force-pushed the github-359 branch 2 times, most recently from d93d457 to 88560b7 Compare November 9, 2020 12:08
@nicolaferraro
Copy link
Member

I got something wrong in the catalog:

    camel-k-cron:
      groupId: org.apache.camel.k
      artifactId: camel-k-cron
      schemes:
      - id: cron
        http: true
        passive: false
    camel-k-kamelet:
      groupId: org.apache.camel.k
      artifactId: camel-k-kamelet
      schemes:
      - id: kamelet
        http: false
        passive: true

Cron is not http, while kamelet is not necessarily passive (most of the times it's active actually).
We've already had a discussion about kamelets but I don't remember what was the right way to set it... I mean there's no good way probably, but how we deal with them?

@nicolaferraro
Copy link
Member

I got something wrong in the catalog:

    camel-k-cron:
      groupId: org.apache.camel.k
      artifactId: camel-k-cron
      schemes:
      - id: cron
        http: true
        passive: false
    camel-k-kamelet:
      groupId: org.apache.camel.k
      artifactId: camel-k-kamelet
      schemes:
      - id: kamelet
        http: false
        passive: true

Cron is not http, while kamelet is not necessarily passive (most of the times it's active actually).
We've already had a discussion about kamelets but I don't remember what was the right way to set it... I mean there's no good way probably, but how we deal with them?

Ok, kamelet should be right, because the template is added as additional source and analyzed.

@nicolaferraro
Copy link
Member

@lburgazzoli
Copy link
Contributor Author

@lburgazzoli lburgazzoli marked this pull request as ready for review November 9, 2020 17:37
@lburgazzoli lburgazzoli merged commit 6d3a8ca into apache:master Nov 9, 2020
@lburgazzoli lburgazzoli deleted the github-359 branch November 9, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants