Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yaml-dsl-autogen #322

Merged
merged 3 commits into from
May 7, 2020
Merged

yaml-dsl-autogen #322

merged 3 commits into from
May 7, 2020

Conversation

lburgazzoli
Copy link
Contributor

No description provided.

@lburgazzoli lburgazzoli changed the title platform-http: split initialization and start phase yaml-dsl-autogen May 7, 2020
@davsclaus
Copy link
Contributor

Ah this is great. So you find the model classes with those JAXB annotations, and then filter on label to get the "eip"'s and then skip some with has custom implementations, and otherwise generate for those as they are more straightforward and can be generated.

@lburgazzoli lburgazzoli force-pushed the yaml-dsl-autogen branch 2 times, most recently from 99849fd to 142f294 Compare May 7, 2020 10:56
@lburgazzoli lburgazzoli marked this pull request as ready for review May 7, 2020 11:53
@lburgazzoli lburgazzoli force-pushed the yaml-dsl-autogen branch 2 times, most recently from e362c82 to 1a06b98 Compare May 7, 2020 13:52
valdar
valdar requested changes May 7, 2020
View reviewed changes
Copy link
Member

@valdar valdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope to have understood correctly the spirit of the PR :D

...-plugin/src/main/java/org/apache/camel/k/tooling/maven/GenerateYamlLoaderSupportClasses.java Outdated Show resolved Hide resolved
...-plugin/src/main/java/org/apache/camel/k/tooling/maven/GenerateYamlLoaderSupportClasses.java Outdated Show resolved Hide resolved
@lburgazzoli
Copy link
Contributor Author

ok to test

@lburgazzoli lburgazzoli merged commit b866293 into apache:master May 7, 2020
@lburgazzoli lburgazzoli deleted the yaml-dsl-autogen branch May 7, 2020 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@davsclaus davsclaus davsclaus approved these changes

@valdar valdar valdar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lburgazzoli @davsclaus @valdar @oscerd