Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix apache/camel-k#1119: do not return cloud events by default #208

Merged
merged 4 commits into from
Dec 13, 2019
Merged

Fix apache/camel-k#1119: do not return cloud events by default #208

merged 4 commits into from
Dec 13, 2019

Conversation

nicolaferraro
Copy link
Member

and deprecate automatic json serialization.

lburgazzoli
lburgazzoli reviewed Dec 13, 2019
View reviewed changes
...ve/camel-knative/src/main/java/org/apache/camel/component/knative/KnativeReplyProcessor.java Outdated

// remove CloudEvent headers
for (CloudEvent.Attribute attr : cloudEventProcessor.cloudEvent().attributes()) {
exchange.getMessage().removeHeader(attr.http());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be part of the transport processor ? as it is the only one that know how headers are mapped

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let me move it

@nicolaferraro
Copy link
Member Author

How does it look?

@lburgazzoli
Copy link
Contributor

better :)

wonder if removeEventHeadersInReply should be an endpoint property and a service metadata instead of a transport option

@nicolaferraro
Copy link
Member Author

It seems strange as service metadata, since they are computed externally. And it tracks the replyWithCloudEvent endpoint option, but the camel-knative-http project is not aware of the camel-knative project where the endpoint is defined....

I also don't like it a lot.. suggestions?

@lburgazzoli
Copy link
Contributor

leave it as it is for the moment, at least till we rewrite the component once more :)

@lburgazzoli
Copy link
Contributor

ok to test

@asf-ci
Copy link

asf-ci commented Dec 13, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-k-runtime-pr/15/

@lburgazzoli lburgazzoli merged commit 5fd7e2f into apache:master Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@lburgazzoli lburgazzoli lburgazzoli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolaferraro @lburgazzoli @asf-ci @oscerd