Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't set Knative broker name #535

Closed
nicolaferraro opened this issue Oct 23, 2020 · 3 comments · Fixed by #539
Closed

Can't set Knative broker name #535

nicolaferraro opened this issue Oct 23, 2020 · 3 comments · Fixed by #539
Milestone

Comments

@nicolaferraro
Copy link
Member

nicolaferraro commented Oct 23, 2020

Issue #151 talks about params like brokerApiVersion and brokerName as ways to set the source/target broker, but they are not present in the codebase.

While we can just use apiVersion (which is already present), setting brokerName (or better, just name) in the URI results in an error.

Parameter name is an URI endpoint when using knative:endpooint and knative:channel, but not with knative:event.

@nicolaferraro nicolaferraro added this to the 1.6.0 milestone Oct 23, 2020
@lburgazzoli
Copy link
Contributor

It does not work because name is a path param so for endpoint and channel the name is already part of the uri however for event, name is used to identify the event type.

To fix it I think we have 3 options:

  1. rename the path param from name to id and introduce name
  2. use better name to set kubernetes resource, like resourceName, resourceType, resourceApiVersion
  3. rename the path param from name to id and use better name to set kubernetes resource

@nicolaferraro
Copy link
Member Author

Option 1 seems the most backward compatible. How would name behave for endpoint and channel?

@lburgazzoli
Copy link
Contributor

Name is only used to look up resource definitions from knative env so it is an internal detail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants