Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove suport for "configuration" classes #480

Closed
lburgazzoli opened this issue Sep 18, 2020 · 2 comments · Fixed by #481
Closed

Remove suport for "configuration" classes #480

lburgazzoli opened this issue Sep 18, 2020 · 2 comments · Fixed by #481
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@lburgazzoli
Copy link
Contributor

lburgazzoli commented Sep 18, 2020

As today, the runtime supports loading configuration classes written in Java so as example:

class MyBeans {
    @BindToRegistry
    Processor myProcessor() {
        return ...;
    }
}

Those kind of classes may be sometime useful but given that we want to focus on the routes and that if needed such classes can be provided by a jar and referenced through camel-main's configuration properties, I'm proposing to drop them which has the nice side effect to dramatically simplify the code and allow to contribute the source loading mechanics to Camel.

Using @BindToRegistry and other annotations will of course be possible on RouteBuilder classes.

@lburgazzoli lburgazzoli added the question Further information is requested label Sep 18, 2020
@lburgazzoli
Copy link
Contributor Author

@nicolaferraro @davsclaus what do you think ?

@davsclaus
Copy link
Contributor

Fine with me, less special camel-k then maybe better

@lburgazzoli lburgazzoli self-assigned this Sep 21, 2020
@lburgazzoli lburgazzoli added this to the 1.5.0 milestone Sep 21, 2020
@lburgazzoli lburgazzoli added enhancement New feature or request and removed question Further information is requested labels Sep 21, 2020
lburgazzoli added a commit to lburgazzoli/apache-camel-k-runtime that referenced this issue Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants