-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of deprecated VS Code Didact #97
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool cleanup, thanks!
d288129
to
97b694d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you forgot to swith resource-file-xyz
examples. You've also removing resources-data
files which were used by those examples.
I removed it because I thought it was deprecated ...
Also when I try it I see ...
Are we expecting folks to load that file content in a configmap first? Also,
|
This commit removes We don't have |
We don't need to have parity between tests and examples. Examples are typically more oriented to show basic or complex use cases for users. I think in this case we do need to convert the binary and base64 from groovy to yaml and moving also from file to configmap (if no other similar example is already available, of course) as it is a useful demo scenario to show. |
I now migrated and restored all With
|
This is ready to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just noticed something that would require some attention. We're missing to add some comment line to explain in the same example how to run it. For example, in the groovy example we used to have:
//
// To run this integrations use:
//
// kubectl create configmap my-cm --from-literal=my-configmap-key="configmap content"
// kamel run --resource configmap:my-cm@/tmp/app/data resource-configmap-location-route.groovy --dev
//
And now we're missing it in the new example. I think we must bring this comment back in the new specific dsl format, of course.
Update generic languages, env, cron