[CALCITE-4215] Use default trait value if traitSupplier returns null

apache · Oct 1, 2020 · 97e4f0c · 97e4f0c
1 parent ec5b75a
commit 97e4f0c
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/core/src/main/java/org/apache/calcite/plan/RelTraitSet.java b/core/src/main/java/org/apache/calcite/plan/RelTraitSet.java
@@ -240,6 +240,9 @@ public <T extends RelMultipleTrait> RelTraitSet replaceIfs(RelTraitDef<T> def,
       return this; // trait is not enabled; ignore it
     }
     final List<T> traitList = traitSupplier.get();
+    if (traitList == null) {
+      return replace(index, def.getDefault());
+    }
     return replace(index, RelCompositeTrait.of(def, traitList));
   }
 
@@ -250,7 +253,10 @@ public <T extends RelTrait> RelTraitSet replaceIf(RelTraitDef<T> def,
     if (index < 0) {
       return this; // trait is not enabled; ignore it
     }
-    final T traitList = traitSupplier.get();
+    T traitList = traitSupplier.get();
+    if (traitList == null) {
+      traitList = def.getDefault();
+    }
     return replace(index, traitList);
   }