Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pylint config and fix some trivial issues #1717

Closed
wants to merge 3 commits into from

Conversation

ssssam
Copy link
Contributor

@ssssam ssssam commented Aug 12, 2022

This enables lint test to pass with Pylint >= 2.14.

Merge two strings on the same line into one.
The no-space-check option was removed: https://pylint.pycqa.org/en/latest/whatsnew/2/2.6/summary.html#other-changes

The no-self-use and bad-continuation checks are now in plugins, so
are already disabled by default.

Putting the `##############` header on the same line as `disable=` leads
to it being processed as a value rather than a comment.
Merge two strings on one line into one.
@ssssam
Copy link
Contributor Author

ssssam commented Aug 12, 2022

Seems this cannot work as-is with Pylint 2.13, as the no-self-use checks needs to be disabled there.

@gtristan
Copy link
Contributor

Seems this cannot work as-is with Pylint 2.13, as the no-self-use checks needs to be disabled there.

Better not try to submit this change separately to the branch which updates the requirements.

@ssssam
Copy link
Contributor Author

ssssam commented Aug 12, 2022

Yes, can merge into #1714 if that's acceptable

@ssssam ssssam closed this Aug 12, 2022
@gtristan
Copy link
Contributor

Yes, can merge into #1714 if that's acceptable

Of course

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants