Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-implement contrib/bst-graph as part of BuildStream #1915

Open
nanonyme opened this issue Apr 22, 2024 · 0 comments · May be fixed by #1949
Open

Re-implement contrib/bst-graph as part of BuildStream #1915

nanonyme opened this issue Apr 22, 2024 · 0 comments · May be fixed by #1949

Comments

@nanonyme
Copy link
Contributor

The tool is a complete hack as is. This kind of a tool is very useful though so let's re-implement it as part of BuildStream as command bst graph so it can use internal API.
ion232 added a commit to ion232/buildstream that referenced this issue Aug 12, 2024
@ion232
Add bst graph command
24179c8 
Adds a new command to bst called 'graph' which reimplements the same API
and functionality as contrib/bst-graph. The implementation details are
within _stream.py as another function called 'graph'.

Part of apache#1915.
@ion232 ion232 linked a pull request Aug 12, 2024 that will close this issue
Draft
ion232 added a commit to ion232/buildstream that referenced this issue Aug 13, 2024
@ion232
Add bst graph command
9faeca8 
Adds a new command to bst called 'graph' which reimplements the same API
and functionality as contrib/bst-graph. The implementation details are
within _stream.py as another function called 'graph'.

Part of apache#1915.
ion232 added a commit to ion232/buildstream that referenced this issue Aug 13, 2024
@ion232
Make buildtime and runtime graphs separate renders
bd1aaff 
It can already be difficult to tell what's going on in large graphs.
This commit helps make the graphs clearer and smaller.
However this is no longer the same functionality as in the original
contrib/bst-graph.

Part of apache#1915.
ion232 added a commit to ion232/buildstream that referenced this issue Aug 13, 2024
@ion232
Remove contrib/bst-graph
beaf9f0 
This is no longer needed when reimplemented into buildstream itself.

Part of apache#1915.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add bst graph command ion232/buildstream
1 participant
@nanonyme