method level option to ignore server eovercrowded #2820
+115
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenBright
reviewed
Nov 16, 2024
| @@ -586,6 +586,11 @@ void ProcessRpcRequest(InputMessageBase* msg_base) { | |||
| mp->service->CallMethod(mp->method, cntl.get(), &breq, &bres, NULL); | |||
| break; | |||
| } | |||
| if (socket->is_overcrowded() && !server->options().ignore_eovercrowded && !mp->ignore_eovercrowded) { | |||
| @@ -1495,7 +1495,7 @@ void ProcessHttpRequest(InputMessageBase *msg) { | |||
| // NOTE: accesses to builtin services are not counted as part of | |||
| // concurrency, therefore are not limited by ServerOptions.max_concurrency. | |||
| if (!sp->is_builtin_service && !sp->params.is_tabbed) { | |||
| if (socket->is_overcrowded() && !server->options().ignore_eovercrowded) { | |||
| if (socket->is_overcrowded() && !server->options().ignore_eovercrowded && !sp->ignore_eovercrowded) { | |||
| @@ -454,6 +448,12 @@ void ProcessHuluRequest(InputMessageBase* msg_base) { | |||
| sp->service->CallMethod(sp->method, cntl.get(), &breq, &bres, NULL); | |||
| break; | |||
| } | |||
| if (socket->is_overcrowded() && !server->options().ignore_eovercrowded && !sp->ignore_eovercrowded) { | |||
| @@ -406,6 +400,11 @@ void ProcessSofaRequest(InputMessageBase* msg_base) { | |||
| meta.method().c_str()); | |||
| break; | |||
| } | |||
| if (socket->is_overcrowded() && !server->options().ignore_eovercrowded && !sp->ignore_eovercrowded) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number:
Problem Summary:
What is changed and the side effects?
Changed: add a method-level option(only valid for baidu_rpc, http_rpc, hulu_pbrpc and sofa_pbrpc protocols) to enable ignore eovercrowded errors for some methods.
Side effects:
Performance effects(性能影响): no or little
Breaking backward compatibility(向后兼容性):
Check List: