Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix LoadBalancerWithNaming memory leak when ssl init failed #2503

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

ehds
Copy link
Contributor

@ehds ehds commented Jan 11, 2024

What problem does this PR solve?

Issue Number:

Problem Summary:
lb (LoadBalancerWithNaming) 可能内存泄漏当 CreateSocketSSLContext 失败时。

What is changed and the side effects?

Changed:
使用 unique_ptr 包裹 lb 临时对象,并在成功完成初始化后,将其生命周期转移给 _lb.

Side effects:

  • Performance effects(性能影响):
  • Breaking backward compatibility(向后兼容性):

Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@chenBright
Copy link
Contributor

LGTM

@chenBright chenBright merged commit b8d45bb into apache:master Jan 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants