Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Branch-4.14] Remove unused dependencies #4233

Conversation

hangc0276
Copy link
Contributor

(cherry picked from commit 174c90d33ac523af3cbce11a1f1f6a258ccd0139)

Descriptions of the changes in this PR:

Motivation

The PR #4232 upgrade grpc version to fix CVEs, but it introduced two unused dependencies. I pushed this PR to remove them

Changes

(Describe: what changes you have made)

Master Issue: #


In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
checks for pull requests. A pull request can only be merged when it passes precommit checks.


Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

If this PR is a BookKeeper Proposal (BP):

  • Make sure the PR title is formatted like:
    <BP-#>: Description of bookkeeper proposal
    e.g. BP-1: 64 bits ledger is support
  • Attach the master issue link in the description of this PR.
  • Attach the google doc link if the BP is written in Google Doc.

Otherwise:

  • Make sure the PR title is formatted like:
    <Issue #>: Description of pull request
    e.g. Issue 123: Description ...
  • Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • Replace <Issue #> in the title with the actual Issue number.

(cherry picked from commit 174c90d33ac523af3cbce11a1f1f6a258ccd0139)
@hangc0276 hangc0276 requested review from eolivelli and zymap March 18, 2024 07:14
@hangc0276 hangc0276 self-assigned this Mar 18, 2024
@hangc0276 hangc0276 merged commit b7a9164 into apache:branch-4.14 Mar 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants