Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mockito instead of powermock #4212

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

nodece
Copy link
Member

@nodece nodece commented Feb 19, 2024

Closes #4201

Motivation

PowerMock is no longer maintained. The last release way in January 2020.

Changes

  • Use mockito instead of powermock in the codebase
  • Remove powermock library from pom.xml
  • Change some code is used for mock/spy object

@nodece nodece force-pushed the use-mockit-instead-of-powermock branch 5 times, most recently from 6a0dc1b to ecd2c20 Compare February 20, 2024 07:17
@nodece nodece force-pushed the use-mockit-instead-of-powermock branch from ecd2c20 to b1179da Compare February 20, 2024 09:34
@nodece nodece closed this Feb 20, 2024
@nodece nodece reopened this Feb 20, 2024
@merlimat merlimat merged commit ee56a95 into apache:master Feb 20, 2024
42 of 43 checks passed
@lhotari
Copy link
Member

lhotari commented Feb 20, 2024

Great job @nodece

@lhotari
Copy link
Member

lhotari commented Feb 20, 2024

@nodece the next step would be to upgrade Mockito to 4.11. That's the last version that supports Java 8. Would you like to handle it. There are some minor breaking changes in Mockito between 3.x -> 4.x. the upgrade PR in Pulsar could be a useful reference

Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace the usage of PowerMock with Mockito in the Bookkeeper tests
3 participants