Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3206: Flaky-test: BookieZKExpireTest.testBookieServerZKExpireBehaviour #3415

Merged
merged 2 commits into from
Jul 21, 2022

Conversation

dlg99
Copy link
Contributor

@dlg99 dlg99 commented Jul 21, 2022

Motivation

Flaky test

Changes

AFAICT from my repro, the test flakes depending whether the ZK client gets the SessionExpired error or not.
Reworked the test to reflect the behavior, added some logging.

Master Issue: #3206

@StevenLuMT
Copy link
Member

rerun failure checks

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

I left one comment about the test

Good catch

@nicoloboschi nicoloboschi merged commit 0b910db into apache:master Jul 21, 2022
@nicoloboschi nicoloboschi added this to the 4.16.0 milestone Jul 21, 2022
@hangc0276
Copy link
Contributor

Good catch.

zymap pushed a commit that referenced this pull request Sep 23, 2022
…haviour (#3415)

* Issue 3206: Flaky-test: BookieZKExpireTest.testBookieServerZKExpireBehaviour

* clear property at the end of the test

(cherry picked from commit 0b910db)
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
…haviour (apache#3415)

* Issue 3206: Flaky-test: BookieZKExpireTest.testBookieServerZKExpireBehaviour

* clear property at the end of the test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants