fix: windows test failure in ConfigDefTest

Signed-off-by: ZhangJian He <[email protected]>
apache · Apr 9, 2024 · 53ce6cc · 53ce6cc
1 parent 8fd32b5
commit 53ce6cc
Showing 1 changed file with 11 additions and 6 deletions.
diff --git a/bookkeeper-common/src/test/java/org/apache/bookkeeper/common/conf/ConfigDefTest.java b/bookkeeper-common/src/test/java/org/apache/bookkeeper/common/conf/ConfigDefTest.java
@@ -27,10 +27,11 @@
 import static org.junit.Assert.assertTrue;
 
 import com.google.common.collect.Lists;
-import com.google.common.io.ByteStreams;
+import java.io.BufferedReader;
 import java.io.ByteArrayOutputStream;
 import java.io.IOException;
 import java.io.InputStream;
+import java.io.InputStreamReader;
 import java.util.Iterator;
 import java.util.Set;
 import lombok.extern.slf4j.Slf4j;
@@ -280,11 +281,15 @@ public void testBuildConfigDef() {
 
     @Test
     public void testSaveConfigDef() throws IOException  {
-        byte[] confData;
-        try (InputStream is = this.getClass().getClassLoader().getResourceAsStream("test_conf_2.conf")) {
-            confData = new byte[is.available()];
-            ByteStreams.readFully(is, confData);
+        StringBuilder sb = new StringBuilder();
+        try (InputStream is = this.getClass().getClassLoader().getResourceAsStream("test_conf_2.conf");
+             BufferedReader reader = new BufferedReader(new InputStreamReader(is, UTF_8))) {
+            String line;
+            while ((line = reader.readLine()) != null) {
+                sb.append(line).append(System.lineSeparator());
+            }
         }
+        String confData = sb.toString();
 
         ConfigDef configDef = ConfigDef.of(TestConfig2.class);
         String readConf;
@@ -294,7 +299,7 @@ public void testSaveConfigDef() throws IOException  {
             log.info("\n{}", readConf);
         }
 
-        assertEquals(new String(confData, UTF_8), readConf);
+        assertEquals(confData, readConf);
     }
 
 }