[BEAM-6076] Fetch only required fields for BigQuery Table #7066
Conversation
Before this change, all table fields were fetched which caused a NullPointerException in StandardTableDefinition.java class - the specific reason is that StreamingBuffer's "estimatedRows" field is sometimes null. This change makes the client to skip fetching This field so that it doesn't use the erroneous code.
|
I think this will settle the problem. As far as I can tell, the problematic field was estimated rows field that sometimes seems to be null (hence NPE when calling Other than that such query will be a little bit more resource-efficient since the response body is smaller now (not fetching all fields of Table JSON). @apilloud could you take a look? |
|
For reference: googleapis/google-cloud-java#3982 |
|
Run JavaPortabilityApi PreCommit |
|
Despite the fact that this issue is not happening anymore (we might be lucky) I'm merging this. Fetching all fields is still not needed so it's a good improvement. Thanks! |
Before this change, all table fields were fetched which caused a
NullPointerException in StandardTableDefinition.java class -
the specific reason is that StreamingBuffer's "estimatedRows"
field is sometimes null. This change makes the client to skip fetching
this field so that it doesn't use the erroneous code.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)