Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input boxes for required user inputs #33183

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

claudevdm
Copy link
Contributor

@claudevdm claudevdm commented Nov 21, 2024

Add input boxes to user required inputs in example notebooks.

Colab diffs:
automatic_model_refresh

automatic_model_refresh.ipynb
bigquery_enrichment_transform.ipynb
bigtable_enrichment_transform.ipynb
vertex_ai_text_embeddings.ipynb
dataframe_api_preprocessing.ipynb
gemma_2_sentiment_and_summarization.ipynb
nlp_tensorflow_streaming.ipynb
run_inference_pytorch.ipynb
run_inference_sklearn.ipynb
run_inference_tensorflow.ipynb
run_inference_tensorflow_with_tfx.ipynb
run_inference_vertex_ai.ipynb
run_inference_vllm.ipynb
vertex_ai_feature_store_enrichment.ipynb
beam_nlp.ipynb

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@claudevdm claudevdm force-pushed the input-box-notebooks branch 2 times, most recently from 3c368af to 28426c2 Compare November 21, 2024 18:44
@claudevdm
Copy link
Contributor Author

R: @damccorm

@claudevdm claudevdm marked this pull request as ready for review November 21, 2024 19:39
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had 2 minor comments, otherwise LGTM.

"\n"
]
}
],
"source": [
"model = tf.keras.applications.resnet.ResNet101()\n",
"model.save('resnet101_weights_tf_dim_ordering_tf_kernels.keras')\n",
"# After saving the model locally, upload the model to GCS bucket and provide that gcs bucket `URI` as `model_uri` to the `TFModelHandler`\n",
"# Replace `BUCKET_NAME` value with actual bucket name.\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get rid of this comment now?

"\n"
]
}
],
"source": [
"model = tf.keras.applications.resnet.ResNet152()\n",
"model.save('resnet152_weights_tf_dim_ordering_tf_kernels.keras')\n",
"# Replace the `BUCKET_NAME` with the actual bucket name.\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same - can we get rid of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants