-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add input boxes for required user inputs #33183
base: master
Are you sure you want to change the base?
Conversation
3c368af
to
28426c2
Compare
28426c2
to
e6c456e
Compare
R: @damccorm |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had 2 minor comments, otherwise LGTM.
"\n" | ||
] | ||
} | ||
], | ||
"source": [ | ||
"model = tf.keras.applications.resnet.ResNet101()\n", | ||
"model.save('resnet101_weights_tf_dim_ordering_tf_kernels.keras')\n", | ||
"# After saving the model locally, upload the model to GCS bucket and provide that gcs bucket `URI` as `model_uri` to the `TFModelHandler`\n", | ||
"# Replace `BUCKET_NAME` value with actual bucket name.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get rid of this comment now?
"\n" | ||
] | ||
} | ||
], | ||
"source": [ | ||
"model = tf.keras.applications.resnet.ResNet152()\n", | ||
"model.save('resnet152_weights_tf_dim_ordering_tf_kernels.keras')\n", | ||
"# Replace the `BUCKET_NAME` with the actual bucket name.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same - can we get rid of this?
Add input boxes to user required inputs in example notebooks.
Colab diffs:
automatic_model_refresh
automatic_model_refresh.ipynb
bigquery_enrichment_transform.ipynb
bigtable_enrichment_transform.ipynb
vertex_ai_text_embeddings.ipynb
dataframe_api_preprocessing.ipynb
gemma_2_sentiment_and_summarization.ipynb
nlp_tensorflow_streaming.ipynb
run_inference_pytorch.ipynb
run_inference_sklearn.ipynb
run_inference_tensorflow.ipynb
run_inference_tensorflow_with_tfx.ipynb
run_inference_vertex_ai.ipynb
run_inference_vllm.ipynb
vertex_ai_feature_store_enrichment.ipynb
beam_nlp.ipynb
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.