Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit language_level=3 arg to Cythonize #26015

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

jrmccluskey
Copy link
Contributor

Adds an explicit lanugage_level=3 arg to Cythonize() in an effort to suppress warnings and avoid accidental usage of Cythonize targeting Python 2.

Fixes #25979


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrmccluskey
Copy link
Contributor Author

Run Python PreCommit

Copy link
Contributor

@robertwb robertwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this.

@jrmccluskey
Copy link
Contributor Author

Confirmed that the cython tests in the precommit no longer have the warning. Will let everything go green before merging

@jrmccluskey
Copy link
Contributor Author

Run PythonLint PreCommit

@jrmccluskey
Copy link
Contributor Author

Run RAT PreCommit

@jrmccluskey
Copy link
Contributor Author

Run Portable_Python PreCommit

@jrmccluskey
Copy link
Contributor Author

Everything got cancelled by Jenkins restarting but we've confirmed the fix so I'm comfortable merging

@jrmccluskey jrmccluskey merged commit 14a7782 into apache:master Mar 28, 2023
@jrmccluskey jrmccluskey deleted the ohsaycanyouc branch March 28, 2023 21:29
tvalentyn added a commit that referenced this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cythonization is compiled with language level 2
3 participants