Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Akvelon editor (#23415) #23825

Merged
merged 2 commits into from
Oct 27, 2022
Merged

Conversation

alexeyinkin
Copy link
Contributor

@alexeyinkin alexeyinkin commented Oct 25, 2022


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@@ -390,6 +402,13 @@ packages:
url: "https://pub.dartlang.org"
source: hosted
version: "0.7.0"
hive:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was brought by https://pub.dev/packages/autotrie
and will be tree-shaken away.

@alexeyinkin alexeyinkin marked this pull request as ready for review October 25, 2022 12:58
@alexeyinkin
Copy link
Contributor Author

R: @damondouglas

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@alexeyinkin
Copy link
Contributor Author

Fixed the bug that had been moving cursor to the top, akvelon/flutter-code-editor#81

Copy link
Contributor

@damondouglas damondouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pabloem (cc: @alexeyinkin ) LGTM with the following note:
We discussed in the meeting that the flutter_code_editor is soon to be published at https://pub.dev/.

@alexeyinkin
Copy link
Contributor Author

It is public, just unlisted in search. Use the the direct link for it: https://pub.dev/packages/flutter_code_editor
An even the search has "Include unlisted" option.
So the package is pretty much visible.

@pabloem
Copy link
Member

pabloem commented Oct 27, 2022

exciting. thanks!

@pabloem pabloem merged commit acd9cbe into apache:master Oct 27, 2022
@damondouglas
Copy link
Contributor

Wow I didn't even know that was an option. No wonder why I was able to build it locally. 🫣

ryanthompson591 pushed a commit to ryanthompson591/beam that referenced this pull request Oct 28, 2022
* Use Akvelon editor (apache#23415)

* Upgrade Akvelon editor (apache#23415)
ruslan-ikhsan pushed a commit to akvelon/beam that referenced this pull request Nov 11, 2022
* Use Akvelon editor (apache#23415)

* Upgrade Akvelon editor (apache#23415)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Replace Playground code editor with Akvelon editor
3 participants