-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Akvelon editor (#23415) #23825
Use Akvelon editor (#23415) #23825
Conversation
@@ -390,6 +402,13 @@ packages: | |||
url: "https://pub.dartlang.org" | |||
source: hosted | |||
version: "0.7.0" | |||
hive: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was brought by https://pub.dev/packages/autotrie
and will be tree-shaken away.
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Fixed the bug that had been moving cursor to the top, akvelon/flutter-code-editor#81 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pabloem (cc: @alexeyinkin ) LGTM with the following note:
We discussed in the meeting that the flutter_code_editor
is soon to be published at https://pub.dev/.
It is public, just unlisted in search. Use the the direct link for it: https://pub.dev/packages/flutter_code_editor |
exciting. thanks! |
Wow I didn't even know that was an option. No wonder why I was able to build it locally. 🫣 |
* Use Akvelon editor (apache#23415) * Upgrade Akvelon editor (apache#23415)
* Use Akvelon editor (apache#23415) * Upgrade Akvelon editor (apache#23415)
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.