Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name all Java threads to aid in debugging #23049 #23380

Closed
wants to merge 8 commits into from

Conversation

Geddy05
Copy link
Contributor

@Geddy05 Geddy05 commented Sep 27, 2022

Name all Java threads to aid in debugging #23049

R: @kennknowles for label java.
R: @Abacn for label io.

Geddy05 and others added 3 commits September 27, 2022 13:25
…23173)

* Add a tensorflow example to the run_inference_basic notebook

* added tensorflow notebook example

* updated first comment

* added license

* added sklearn notebook

* added pytorch example

* added readme

* added notebooks for various frameworks

* updated notebooks and readme

* Update examples/notebooks/beam-ml/README.md

Co-authored-by: Danny McCormick <[email protected]>

* Update examples/notebooks/beam-ml/run_inference_tensorflow.ipynb

Co-authored-by: Danny McCormick <[email protected]>

* Added keyed handler, fixed formatting of floats to limit to 2 digits

* Update examples/notebooks/beam-ml/run_inference_sklearn.ipynb

good catch

Co-authored-by: Danny McCormick <[email protected]>

* Update examples/notebooks/beam-ml/README.md

* Update examples/notebooks/beam-ml/README.md

Co-authored-by: Danny McCormick <[email protected]>
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #23380 (c36077a) into master (3c91e7b) will decrease coverage by 0.28%.
The diff coverage is n/a.

❗ Current head c36077a differs from pull request most recent head 7c74e0a. Consider uploading reports for the commit 7c74e0a to get more accurate results

@@            Coverage Diff             @@
##           master   #23380      +/-   ##
==========================================
- Coverage   73.68%   73.40%   -0.29%     
==========================================
  Files         714      718       +4     
  Lines       95220    95652     +432     
==========================================
+ Hits        70161    70211      +50     
- Misses      23762    24130     +368     
- Partials     1297     1311      +14     
Flag Coverage Δ
go 50.89% <ø> (-0.19%) ⬇️
python 83.16% <ø> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/go/pkg/beam/core/runtime/exec/fullvalue.go 77.24% <0.00%> (-6.35%) ⬇️
...s/interactive/dataproc/dataproc_cluster_manager.py 71.72% <0.00%> (-5.70%) ⬇️
sdks/go/pkg/beam/core/runtime/exec/datasource.go 62.00% <0.00%> (-4.30%) ⬇️
sdks/python/apache_beam/internal/pickler.py 92.00% <0.00%> (-3.46%) ⬇️
sdks/python/apache_beam/utils/interactive_utils.py 95.12% <0.00%> (-2.44%) ⬇️
sdks/go/pkg/beam/core/runtime/graphx/coder.go 51.91% <0.00%> (-1.82%) ⬇️
sdks/python/apache_beam/io/source_test_utils.py 88.01% <0.00%> (-1.39%) ⬇️
sdks/go/pkg/beam/core/runtime/exec/coder.go 57.74% <0.00%> (-1.29%) ⬇️
sdks/python/apache_beam/internal/metrics/metric.py 93.00% <0.00%> (-1.00%) ⬇️
sdks/python/apache_beam/io/localfilesystem.py 90.97% <0.00%> (-0.76%) ⬇️
... and 37 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.
R: @Abacn for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn
Copy link
Contributor

Abacn commented Sep 27, 2022

Thanks for contributions. I see some files under examples/notebooks/beam-ml looks irrelevant. Is there a rebase issue?

@Geddy05
Copy link
Contributor Author

Geddy05 commented Sep 27, 2022

Think so. Because i didn't touch these files

@Geddy05 Geddy05 closed this Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants