Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes CoGroupByKey typehint from List to Iterable #22984

Merged
merged 7 commits into from
Sep 27, 2022
Merged

Changes CoGroupByKey typehint from List to Iterable #22984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a09cdfc
Changes CoGroupByKey typehint from List to Iterable
ryanthompson591 Aug 31, 2022
1d52aaa
Merge branch 'master' into update_cogroupbykey
ryanthompson591 Sep 13, 2022
380fb2f
updated changes.md documentation
ryanthompson591 Sep 13, 2022
930560c
added document to change
ryanthompson591 Sep 13, 2022
ee6cd7c
Update CHANGES.md
ryanthompson591 Sep 13, 2022
71c5cfc
Update CHANGES.md
ryanthompson591 Sep 15, 2022
4420e58
Update CHANGES.md
ryanthompson591 Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@

## Breaking Changes

* X behavior was changed ([#X](https://github.com/apache/beam/issues/X)).
* Python SDK CoGroupByKey outputs an iterable allowing for arbitrarily large results. [#21556](https://github.com/apache/beam/issues/21556) Beam users may see an error on transforms downstream from CoGroupByKey. Users must change methods expecting a List to expect an Iterable going forward. See [document](https://docs.google.com/document/d/1RIzm8-g-0CyVsPb6yasjwokJQFoKHG4NjRUcKHKINu0) for information and fixes.

## Deprecations

Expand Down
3 changes: 1 addition & 2 deletions sdks/python/apache_beam/transforms/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,8 +198,7 @@ def expand(self, pcolls):
input_value_types.append(value_type)
output_key_type = typehints.Union[tuple(input_key_types)]
iterable_input_value_types = tuple(
# TODO: Change List[t] to Iterable[t]
typehints.List[t] for t in input_value_types)
typehints.Iterable[t] for t in input_value_types)

output_value_type = typehints.Dict[
str, typehints.Union[iterable_input_value_types or [typehints.Any]]]
Expand Down