-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pytest to support Python 3.10 #22055
Conversation
Can one of the admins verify this patch? |
4 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Run XVR_JavaUsingPython_Dataflow PostCommit |
Assigning reviewers. If you would like to opt out of this review, comment R: @TheNeuralBit for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
stop reviewer notifications |
Stopping reviewer notifications for this pull request: requested by reviewer |
Codecov Report
@@ Coverage Diff @@
## master #22055 +/- ##
=======================================
Coverage 74.17% 74.17%
=======================================
Files 706 706
Lines 93229 93229
=======================================
+ Hits 69148 69149 +1
+ Misses 22813 22812 -1
Partials 1268 1268
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
9b4fe0d
to
d8f3776
Compare
Run XVR_JavaUsingPython_Dataflow PostCommit |
@AnandInguva should I review this or is it still in progress? |
It's still in progress. I was working on it last week but got occupied with RunInference work. Debugging the X-lang test is taking sometime since the logs aren't useful for the failing test. I will ping you once its ready |
Little context: When I update the pytest version, the X-lang This test works for Python 3.7 and fails for Python 3.9. So I started debugging into it to see where the error happens. |
Run XVR_JavaUsingPython_Dataflow PostCommit |
28d224a
to
4532e78
Compare
Run XVR_JavaUsingPython_Dataflow PostCommit |
R: @tvalentyn |
@@ -2509,6 +2509,7 @@ class BeamModulePlugin implements Plugin<Project> { | |||
// specific binary here could make gradle delete it while pip will believe | |||
// the package is fully installed. | |||
outputs.dirs(project.ext.envdir) | |||
outputs.upToDateWhen { false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch. thanks!
we will have to rerun the requirements generation after #22481 is merged. We need the above change for the release branch, so I am not merging this change yet. also would be good to wait until we cut the release branch before merging this change to avoid a risk of delaying the relelase. |
Run Python 3.7 PostCommit |
Run Python 3.8 PostCommit |
Run Python 3.9 PostCommit |
Run XVR_JavaUsingPython_Dataflow PostCommit |
Run SQL_Java11 PreCommit |
Run Java PreCommit |
Run Python 3.7 PostCommit |
Run Python 3.9 PostCommit |
Run Python 3.8 PostCommit |
Run Java_Examples_Dataflow PreCommit |
Run Python 3.7 PostCommit |
Run Python 3.9 PostCommit |
Run Java_Examples_Dataflow PreCommit |
Run Python 3.8 PostCommit |
Update Pytest to latest version to support Python 3.10
Pytest 6.2.5 is the minimum version that supports Python 3.10
Python 3.10 issue: #21458
Pytest update issue: #22471 .Please take a look at this for additional context
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.