Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pytest to support Python 3.10 #22055

Merged
merged 6 commits into from
Aug 1, 2022

Conversation

AnandInguva
Copy link
Contributor

@AnandInguva AnandInguva commented Jun 24, 2022

Update Pytest to latest version to support Python 3.10

Pytest 6.2.5 is the minimum version that supports Python 3.10

Python 3.10 issue: #21458
Pytest update issue: #22471 .Please take a look at this for additional context


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented Jun 24, 2022

Can one of the admins verify this patch?

4 similar comments
@asf-ci
Copy link

asf-ci commented Jun 24, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented Jun 24, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented Jun 24, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented Jun 24, 2022

Can one of the admins verify this patch?

@AnandInguva
Copy link
Contributor Author

Run XVR_JavaUsingPython_Dataflow PostCommit

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @TheNeuralBit for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@AnandInguva
Copy link
Contributor Author

stop reviewer notifications

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: requested by reviewer

@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #22055 (a8a01f5) into master (48b5349) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22055   +/-   ##
=======================================
  Coverage   74.17%   74.17%           
=======================================
  Files         706      706           
  Lines       93229    93229           
=======================================
+ Hits        69148    69149    +1     
+ Misses      22813    22812    -1     
  Partials     1268     1268           
Flag Coverage Δ
python 83.53% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) ⬇️
...che_beam/runners/interactive/interactive_runner.py 90.06% <0.00%> (-1.33%) ⬇️
...eam/runners/portability/fn_api_runner/execution.py 92.44% <0.00%> (-0.65%) ⬇️
sdks/python/apache_beam/runners/common.py 88.59% <0.00%> (-0.13%) ⬇️
sdks/go/pkg/beam/io/fhirio/common.go 36.58% <0.00%> (ø)
...eam/runners/interactive/interactive_environment.py 92.02% <0.00%> (+0.30%) ⬆️
...ks/python/apache_beam/runners/worker/sdk_worker.py 88.94% <0.00%> (+0.31%) ⬆️
...hon/apache_beam/runners/worker/bundle_processor.py 93.54% <0.00%> (+0.37%) ⬆️
...python/apache_beam/runners/worker/worker_status.py 79.71% <0.00%> (+2.17%) ⬆️
sdks/python/apache_beam/utils/interactive_utils.py 97.56% <0.00%> (+2.43%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@AnandInguva
Copy link
Contributor Author

Run XVR_JavaUsingPython_Dataflow PostCommit

@TheNeuralBit
Copy link
Member

@AnandInguva should I review this or is it still in progress?

@AnandInguva
Copy link
Contributor Author

@AnandInguva should I review this or is it still in progress?

It's still in progress. I was working on it last week but got occupied with RunInference work. Debugging the X-lang test is taking sometime since the logs aren't useful for the failing test. I will ping you once its ready

@AnandInguva
Copy link
Contributor Author

@AnandInguva should I review this or is it still in progress?

Little context: When I update the pytest version, the X-lang JavaUsingPython test fails due to a pickling error. I suspected it may be due to some version mismatch on dependencies between sdk and worker but thats not the case.

This test works for Python 3.7 and fails for Python 3.9. So I started debugging into it to see where the error happens.

@AnandInguva
Copy link
Contributor Author

Run XVR_JavaUsingPython_Dataflow PostCommit

@AnandInguva
Copy link
Contributor Author

Run XVR_JavaUsingPython_Dataflow PostCommit

@AnandInguva AnandInguva changed the title [DONT MERGE]Update pytest Update pytest to support Python 3.10 Jul 27, 2022
@github-actions github-actions bot added the build label Jul 27, 2022
@AnandInguva
Copy link
Contributor Author

R: @tvalentyn

@@ -2509,6 +2509,7 @@ class BeamModulePlugin implements Plugin<Project> {
// specific binary here could make gradle delete it while pip will believe
// the package is fully installed.
outputs.dirs(project.ext.envdir)
outputs.upToDateWhen { false }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch. thanks!

@tvalentyn
Copy link
Contributor

we will have to rerun the requirements generation after #22481 is merged. We need the above change for the release branch, so I am not merging this change yet. also would be good to wait until we cut the release branch before merging this change to avoid a risk of delaying the relelase.

@AnandInguva
Copy link
Contributor Author

Run Python 3.7 PostCommit

@AnandInguva
Copy link
Contributor Author

Run Python 3.8 PostCommit

@AnandInguva
Copy link
Contributor Author

Run Python 3.9 PostCommit

@AnandInguva
Copy link
Contributor Author

Run XVR_JavaUsingPython_Dataflow PostCommit

@tvalentyn
Copy link
Contributor

Run SQL_Java11 PreCommit

@tvalentyn
Copy link
Contributor

Run Java PreCommit

@tvalentyn
Copy link
Contributor

Run Python 3.7 PostCommit

@tvalentyn
Copy link
Contributor

Run Python 3.9 PostCommit

@tvalentyn
Copy link
Contributor

Run Python 3.8 PostCommit

@tvalentyn
Copy link
Contributor

Run Java_Examples_Dataflow PreCommit

@AnandInguva
Copy link
Contributor Author

Run Python 3.7 PostCommit

@AnandInguva
Copy link
Contributor Author

Run Python 3.9 PostCommit

@AnandInguva
Copy link
Contributor Author

Run Java_Examples_Dataflow PreCommit

@AnandInguva
Copy link
Contributor Author

Run Python 3.8 PostCommit

@tvalentyn tvalentyn merged commit aaea703 into apache:master Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants