AVRO-2112: Target .NET Standard/Core in C# #307
Merged
Commits on Jan 12, 2019
-
-
-
AVRO-2112: Ignore C# tests that use System.CodeDom compilation when t…
…argeting .NET Core See https://github.com/dotnet/corefx/issues/12180
-
AVRO-2112: Replace usage of JToken.ToString() in C# projects
In Newtonsoft.Json v3.5, JToken.ToString() returned the raw JSON representation of the token. In later versions of Newtonsoft.Json, JToken.ToString() returns a simple string representation of the value. See the examples below: - v3.5: "\"Hello World\"" - Later versions: "Hello World" In this commit, I've updated the project to work with later versions of Newtonsoft.Json as well as v3.5. I've replaced some usages of JToken.ToString(). When we need the raw JSON representation, we use JsonConvert.Serialize(). When we need the string value of a string JToken, we use JToken.Value<string>().
-
-
-
Revert to only running tests for Avro.test.dll
This is what we were doing on master. I was trying to run the IPC tests, but that has not seemed to work well in our automated builds.
-
-
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.