Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-9837: [Rust][DataFusion] Added provider for variable #8135

Closed
wants to merge 1 commit into from
Closed

ARROW-9837: [Rust][DataFusion] Added provider for variable #8135

wants to merge 1 commit into from

Conversation

wqc200
Copy link
Contributor

@wqc200 wqc200 commented Sep 8, 2020

Select @@Version, @name;

@@Version is a variable, and if we want to get its value, we should get it from outside the system.
@@Version is a system variable, @name is user defined variable.

@github-actions
Copy link

github-actions bot commented Sep 8, 2020

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andygrove
Copy link
Member

Sorry @wqc200 could you rebase again? Another PR got merged, causing this conflict.

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last commit is a merge commit with changes unrelated to this PR.

Please rebase rather than merge.

@wqc200
Copy link
Contributor Author

wqc200 commented Sep 9, 2020

The last commit is a merge commit with changes unrelated to this PR.

Please rebase rather than merge.

Ok, I rebase it now

@andygrove andygrove closed this in 9921c83 Sep 10, 2020
emkornfield pushed a commit to emkornfield/arrow that referenced this pull request Oct 16, 2020
Select @@Version, @name;

@@Version is a variable, and if we want to get its value, we should get it from outside the system.
@@Version is a system variable, @name is user defined variable.

Closes apache#8135 from wqc200/master_variable

Authored-by: wqc200 <[email protected]>
Signed-off-by: Andy Grove <[email protected]>
GeorgeAp pushed a commit to sirensolutions/arrow that referenced this pull request Jun 7, 2021
Select @@Version, @name;

@@Version is a variable, and if we want to get its value, we should get it from outside the system.
@@Version is a system variable, @name is user defined variable.

Closes apache#8135 from wqc200/master_variable

Authored-by: wqc200 <[email protected]>
Signed-off-by: Andy Grove <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants