Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-8770: [C++][CI] Enable arrow-csv-test on s390x #7152

Closed
wants to merge 1 commit into from
Closed

ARROW-8770: [C++][CI] Enable arrow-csv-test on s390x #7152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ jobs:
env:
ARCH: s390x
ARROW_CI_MODULES: "CPP"
ARROW_CSV: "OFF"
ARROW_FLIGHT: "OFF"
ARROW_GANDIVA: "OFF"
ARROW_PARQUET: "OFF"
Expand Down Expand Up @@ -88,7 +87,6 @@ script:
ulimit -c unlimited || :
- |
archery docker run \
-e ARROW_CSV=${ARROW_CSV:-ON} \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this?

Copy link
Member Author

@kiszk kiszk May 12, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was suggested to remove a line at archery docker run in the previous PR when a new flag was enabled. cc @kou

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am neutral on this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, fair enough.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need it if we don't need to change the default -DARROW_CSV.
If we have multiple default definitions, they will confuse us.

-e ARROW_FLIGHT=${ARROW_FLIGHT:-OFF} \
-e ARROW_GANDIVA=${ARROW_GANDIVA:-ON} \
-e ARROW_PARQUET=${ARROW_PARQUET:-ON} \
Expand Down