Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-8064: [Dev] Implement Comment bot via Github actions #6571

Closed
wants to merge 33 commits into from
Closed
Show file tree
Hide file tree
Changes from 31 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .dockerignore
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
# include explicitly
!ci/**
!c_glib/Gemfile
!dev/archery/requirements*.txt
!python/requirements*.txt
!python/manylinux1/**
!python/manylinux2010/**
Expand Down
49 changes: 49 additions & 0 deletions .github/workflows/archery.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

name: Archery

on:
push:
paths:
- '.github/workflows/archery.yml'
- 'dev/archery/**'
pull_request:
paths:
- '.github/workflows/archery.yml'
- 'dev/archery/**'

jobs:

archery:
name: Archery Unittests
runs-on: ubuntu-latest
steps:
- name: Checkout Arrow
uses: actions/checkout@v1
with:
submodules: true
- name: Setup Python
uses: actions/setup-python@v1
with:
python-version: '3.7'
- name: Install
working-directory: dev/archery
run: pip install pytest responses ruamel.yaml -e .
- name: Test
working-directory: dev/archery
run: pytest -v archery
62 changes: 62 additions & 0 deletions .github/workflows/comment_bot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

name: Comment Bot

on:
# TODO(kszucs): support pull_request_review_comment
issue_comment:
types:
- created
- edited

jobs:

debug:
name: Debug
runs-on: ubuntu-latest
steps:
- name: Checkout Arrow
uses: actions/checkout@v2
with:
path: arrow
# in order to generate version number based on git we need the tags
# fetched but checkout@v2 doesn't do that by default
- name: Featch Arrow tags
working-directory: arrow
run: git fetch --depth=1 origin +refs/tags/*:refs/tags/*
# because libgit2 is a dependency of crossbow so prefer conda
- name: Setup Conda
uses: s-weigand/setup-conda@v1
with:
update-conda: true
python-version: 3.7
conda-channels: conda-forge
- name: Instal Archery and Crossbow dependencies
run: |
conda install -y --file arrow/ci/conda_env_crossbow.txt pygithub
pip install -e arrow/dev/archery
- name: Handle Github comment event
env:
ARROW_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
CROSSBOW_GITHUB_TOKEN: ${{ secrets.CROSSBOW_GITHUB_TOKEN }}
run: |
archery trigger-bot \
--event-name ${{ github.event_name }} \
--event-payload ${{ github.event_path }}


20 changes: 20 additions & 0 deletions ci/conda_env_archery.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

click
pygithub
ruamel.yaml
2 changes: 2 additions & 0 deletions ci/docker/conda-integration.dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ ARG node=11
ARG jdk=8
ARG go=1.12

COPY ci/conda_env_archery.yml /arrow/ci/
RUN conda install -q \
--file arrow/ci/conda_env_archery.yml \
numpy \
maven=${maven} \
nodejs=${node} \
Expand Down
8 changes: 7 additions & 1 deletion ci/docker/linux-apt-lint.dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,13 @@ RUN rustup install ${rust} && \
# Use python3 by default in scripts
RUN ln -s /usr/bin/python3 /usr/local/bin/python && \
ln -s /usr/bin/pip3 /usr/local/bin/pip
RUN pip install flake8 cmake_format==0.5.2 click

COPY dev/archery/requirements.txt \
dev/archery/requirements-lint.txt \
/arrow/dev/archery/
RUN pip install \
-r arrow/dev/archery/requirements.txt \
-r arrow/dev/archery/requirements-lint.txt

ENV LC_ALL=C.UTF-8 \
LANG=C.UTF-8
Loading