ARROW-7067: [CI] Disable code coverage on Travis-CI #5778
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
commented
Nov 5, 2019
| @@ -264,7 +264,7 @@ matrix: | |||
| - $TRAVIS_BUILD_DIR/ci/travis_script_go.sh | |||
| after_success: | |||
| - pushd ${TRAVIS_BUILD_DIR}/go/arrow | |||
| - bash <(curl -s https://codecov.io/bash) || echo "Codecov did not collect coverage reports" | |||
| #- bash <(curl -s https://codecov.io/bash) || echo "Codecov did not collect coverage reports" | |||
There was a problem hiding this comment.
@sbinet Do you use the coverage reports? Otherwise, is there something more to do to disable Go coverage?
pitrou
commented
Nov 5, 2019
| after_success: | ||
| - Rscript ../ci/travis_upload_r_coverage.R | ||
| #after_success: | ||
| #- Rscript ../ci/travis_upload_r_coverage.R |
There was a problem hiding this comment.
@nealrichardson Is there something more to do to disable R coverage computation?
There was a problem hiding this comment.
Nope, that'll do it. You can also rm https://github.com/apache/arrow/blob/master/ci/travis_upload_r_coverage.R
|
I didn't get any objection on the ML, so will merge. This can be easily re-enabled anyway. |
kszucs
added a commit
to kszucs/arrow
that referenced
this pull request
Nov 6, 2019
* ARROW-7067: [CI] Disable code coverage on Travis-CI Closes apache#5778 from pitrou/ARROW-7067-travis-disable-coverage and squashes the following commits: bda5ff4 <Antoine Pitrou> ARROW-7067: Disable code coverage on Travis-CI Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]> * ARROW-7058: [C++] FileSystemDataSourceDiscovery should apply partition schemes relative to its base dir @nealrichardson Closes apache#5772 from bkietz/7058-FileSystemDataSourceDisco and squashes the following commits: c0edfa5 <Benjamin Kietzman> make base_dir of partition schemes explicitly optional f2f9689 <Benjamin Kietzman> add DCHECK for path containing selector 1bae5ff <Benjamin Kietzman> ARROW-7058: FilSystemDataSourceDiscovery should apply partition schemes relative to its base dir Authored-by: Benjamin Kietzman <[email protected]> Signed-off-by: François Saint-Jacques <[email protected]> * Refactor docker-compose file and use it with github actions. * Turn off gandiva and flight for the HDFS test [skip ci] * Missing --pyargs argument for the python test command [skip ci] * Add CentOS version to the manylinux image names [skip ci] * Fix manylinux volumes [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.