ARROW-6658: [Rust][Datafusion] Implement AVG expression #5558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm excited to see these PRs! I am away on a business trip so might not be able to review until the end of the week or at the weekend. |
|
@alippai please rebase |
andygrove
reviewed
Oct 4, 2019
andygrove
reviewed
Oct 4, 2019
andygrove
reviewed
Oct 4, 2019
kszucs
pushed a commit
that referenced
this pull request
Oct 5, 2019
I wasn't sure about the datatypes of sum&count (picked the broadest f64 and i64) also it may or may not be better to implement this as SUM()/COUNT(). Either way the changes from mod.rs are needed to test SQL with f64 Closes #5558 from alippai/ARROW-6658 and squashes the following commits: 20cddef <Andy Grove> fix typo 62372f6 <Andy Grove> Remove unwrap cc32f22 <Andy Grove> rebase ebc3acb <Adam Lippai> ARROW-6658: Implement AVG expression Lead-authored-by: Adam Lippai <[email protected]> Co-authored-by: Andy Grove <[email protected]> Signed-off-by: Andy Grove <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't sure about the datatypes of sum&count (picked the broadest f64 and i64) also it may or may not be better to implement this as SUM()/COUNT().
Either way the changes from mod.rs are needed to test SQL with f64