Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-6714: [R] Fix untested RecordBatchWriter case #5518

Closed

Conversation

nealrichardson
Copy link
Member

I noticed this now-defunct call to table() while reviewing another PR. We clearly weren't testing this case because if you were to pass a data.frame in, you'd get a segfault. This patch adds tests and fixes the issue.

@codecov-io
Copy link

Codecov Report

Merging #5518 into master will decrease coverage by 11.41%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5518       +/-   ##
===========================================
- Coverage   88.69%   77.28%   -11.42%     
===========================================
  Files         964       58      -906     
  Lines      128215     4010   -124205     
  Branches     1501        0     -1501     
===========================================
- Hits       113724     3099   -110625     
+ Misses      14126      911    -13215     
+ Partials      365        0      -365
Impacted Files Coverage Δ
r/R/record-batch-writer.R 88.88% <100%> (+28.88%) ⬆️
python/pyarrow/ipc.pxi
cpp/src/parquet/column_page.h
cpp/src/plasma/test/external_store_tests.cc
cpp/src/arrow/array/builder_decimal.cc
cpp/src/plasma/client.cc
cpp/src/arrow/flight/internal.cc
cpp/src/arrow/compute/compute_test.cc
cpp/src/arrow/python/io.cc
python/pyarrow/hdfs.py
... and 898 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46a14db...3c2eb81. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants