ARROW-6091: [Rust] [DataFusion] Implement physical execution plan for LIMIT #5509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alippai
reviewed
Sep 28, 2019
| // collect up to "limit" rows on each partition | ||
| let threads: Vec<JoinHandle<Result<Vec<RecordBatch>>>> = self | ||
| .partitions | ||
| .iter() |
There was a problem hiding this comment.
Would be an overkill to use rayon's par_iter()?
There was a problem hiding this comment.
For this round my plan was to keep things simple and do a second round of optimizations that I've started tracking in https://jira.apache.org/jira/browse/ARROW-6689 and in particular see the subtask https://jira.apache.org/jira/browse/ARROW-6691 related to threading.
There was a problem hiding this comment.
I think that's a "no" for rayon :D
|
@nevi-me @sunchao @paddyhoran Please review when you can. Thanks. |
|
@nevi-me @sunchao @paddyhoran Any objection to me merging this one? |
paddyhoran
approved these changes
Oct 3, 2019
kszucs
pushed a commit
that referenced
this pull request
Oct 5, 2019
… LIMIT Closes #5509 from andygrove/ARROW-6091 and squashes the following commits: cb5c622 <Andy Grove> bump nightly version 00078c7 <Andy Grove> minor optimization 0c91602 <Andy Grove> test passes 40e617f <Andy Grove> unit test 3cb4cab <Andy Grove> start roughing out LIMIT Authored-by: Andy Grove <[email protected]> Signed-off-by: Andy Grove <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.