-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-6630: [Doc] Document C++ file formats #5500
Conversation
3c6b044
to
f864965
Compare
|
||
================= | ||
Reading CSV files | ||
================= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nealrichardson Could you take a quick look at this file and see if it makes things easy to understand?
f864965
to
1fdc5b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely an improvement. Just a few questions. As with the last doc patch, even though there's more to be done here (JSON, Parquet, etc.), IMO this is worth merging whenever and we can continue to iterate on the docs.
Null values are recognized from the spellings stored in | ||
:member:`ConvertOptions::null_values`. The :func:`ConvertOptions::Defaults` | ||
factory method will initialize a number of conventional null spellings such | ||
as ``N/A``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be good to list them all since this is reference documentation.
1fdc5b0
to
aa5c57d
Compare
Ok, I've also added some docs for JSON and (very incomplete) Parquet. I think this can be merged once CI is green. |
|
||
================================= | ||
Reading and writing Parquet files | ||
================================= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wesm If you want to quickly check that this stub doesn't say anything silly :-)
Closes apache#5500 from pitrou/ARROW-6630-file-format-docs and squashes the following commits: aa5c57d <Antoine Pitrou> ARROW-6630: Document C++ file formats Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
No description provided.