Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-6677: [FlightRPC][C++] Document Flight in C++ #5491

Closed
wants to merge 1 commit into from
Closed

ARROW-6677: [FlightRPC][C++] Document Flight in C++ #5491

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 24, 2019

  • Adds StatusDetail to the docs
  • Fixes the Doxygen config to work with ARROW_FLIGHT_EXPORT
  • Adds error codes to the format docs (though they're not part of the formal format)
  • Touches up some docstrings and adds missing classes to the API docs
  • Add a basic description of how to set up a Flight server/client in C++

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@b780c56). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5491   +/-   ##
=========================================
  Coverage          ?   89.23%           
=========================================
  Files             ?      768           
  Lines             ?   112435           
  Branches          ?        0           
=========================================
  Hits              ?   100328           
  Misses            ?    12107           
  Partials          ?        0
Impacted Files Coverage Δ
cpp/src/arrow/status.h 93.54% <ø> (ø)
cpp/src/arrow/flight/types.h 100% <ø> (ø)
cpp/src/arrow/flight/server.h 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b780c56...df8dc13. Read the comment docs.

@pitrou
Copy link
Member

pitrou commented Sep 25, 2019

Rebased and fixed conflict.

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me, thank you!

@pitrou
Copy link
Member

pitrou commented Sep 25, 2019

Triggered a build on my Travis-CI account: https://travis-ci.org/pitrou/arrow/builds/589335380

Will merge when green.

(edit: squashed to get full build)

@pitrou
Copy link
Member

pitrou commented Sep 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants