ARROW-6158: [C++/Python] Validate child array types with type fields of StructArray #5488
Conversation
| return pyarrow_wrap_array(out) | ||
| cdef Array result = pyarrow_wrap_array(out) | ||
| result.validate() | ||
| return result |
There was a problem hiding this comment.
Some of the Array.from_.. did such validation in the end, and some not (like StructArray.from_arrays, which I was fixing here), so updated this now for all from_.. constructors
There was a problem hiding this comment.
We might want to add some constructor microbenchmarks just so we understand the cost involved, but in principle this is okay
Codecov Report
@@ Coverage Diff @@
## master #5488 +/- ##
=========================================
Coverage ? 89.23%
=========================================
Files ? 768
Lines ? 112453
Branches ? 0
=========================================
Hits ? 100344
Misses ? 12109
Partials ? 0
Continue to review full report at Codecov.
|
| return pyarrow_wrap_array(out) | ||
| cdef Array result = pyarrow_wrap_array(out) | ||
| result.validate() | ||
| return result |
There was a problem hiding this comment.
We might want to add some constructor microbenchmarks just so we understand the cost involved, but in principle this is okay
|
Thanks, I can look into the microbenchmarks (in the asv benchmark suite right?) |
https://issues.apache.org/jira/browse/ARROW-6158