Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-6629: [Doc] [C++] Add filesystem docs #5487

Closed
wants to merge 3 commits into from

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Sep 24, 2019

Also adds and improves other C++ doc items.

Also adds and improves other C++ doc items.

==============================
Input / output and filesystems
==============================
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nealrichardson Would be nice to know if this helps.

@pitrou pitrou force-pushed the ARROW-6629-cpp-fs-docs branch from 46d4952 to 895f04a Compare September 24, 2019 15:21
Copy link
Member

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested the rendered docs pages, but I'm heartily +1 on backfilling docs.

Once CI is happy I'll merge, unless there's objection. I'm sure this could be improved further but I don't see a reason to hold it up, particularly if we can sneak it into 0.15.

docs/source/cpp/io.rst Outdated Show resolved Hide resolved
@pitrou
Copy link
Member Author

pitrou commented Sep 24, 2019

Travis-CI build (green): https://travis-ci.org/pitrou/arrow/builds/589009656

AppVeyor doesn't build docs.

@nealrichardson
Copy link
Member

Ok, if you would please accept my "suggestion" (I'm not authorized) or similar, I'll merge.

Co-Authored-By: Neal Richardson <[email protected]>
@pitrou
Copy link
Member Author

pitrou commented Sep 24, 2019

Done.

@nealrichardson
Copy link
Member

Merci!

@pitrou pitrou deleted the ARROW-6629-cpp-fs-docs branch September 24, 2019 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants