Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-6675: [JS] Add scanReverse function to dataFrame and filteredDataframe #5480

Closed
wants to merge 1 commit into from

Conversation

mmaclach
Copy link
Contributor

  • add scanReverse() to dataFrame and filteredDataframe
  • add tests for scanReverse()

- add scanReverse() to dataFrame and filteredDataframe
- add tests for scanReverse()
@wesm
Copy link
Member

wesm commented Sep 23, 2019

Can you open a JIRA issue? Thanks

@codecov-io
Copy link

Codecov Report

Merging #5480 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5480       +/-   ##
===========================================
- Coverage   89.69%   89.58%    -0.11%     
===========================================
  Files         810      102      -708     
  Lines      114853     6628   -108225     
  Branches     1498     1501        +3     
===========================================
- Hits       103021     5938    -97083     
+ Misses      11821      679    -11142     
  Partials       11       11
Impacted Files Coverage Δ
js/src/table.ts 85.45% <ø> (ø) ⬆️
js/src/compute/dataframe.ts 93.27% <100%> (+1.12%) ⬆️
python/pyarrow/ipc.pxi
cpp/src/parquet/column_page.h
cpp/src/plasma/test/external_store_tests.cc
cpp/src/arrow/array/builder_decimal.cc
cpp/src/plasma/client.cc
cpp/src/arrow/compute/compute_test.cc
cpp/src/arrow/python/io.cc
python/pyarrow/hdfs.py
... and 700 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06dc863...01faae8. Read the comment docs.

@mmaclach mmaclach changed the title JS: scanReverse ARROW-6675: Add scanReverse function Sep 24, 2019
@mmaclach
Copy link
Contributor Author

@kszucs kszucs changed the title ARROW-6675: Add scanReverse function ARROW-6675: [JS] Add scanReverse function Sep 25, 2019
@kszucs kszucs changed the title ARROW-6675: [JS] Add scanReverse function ARROW-6675: [JS] [JS] Add scanReverse function to dataFrame and filteredDataframe Sep 25, 2019
@kszucs kszucs changed the title ARROW-6675: [JS] [JS] Add scanReverse function to dataFrame and filteredDataframe ARROW-6675: [JS] Add scanReverse function to dataFrame and filteredDataframe Sep 25, 2019
@kszucs kszucs closed this in d4dcfa9 Sep 25, 2019
@kszucs
Copy link
Member

kszucs commented Sep 25, 2019

Thanks @mmaclach and @trxcllnt !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants