ARROW-6509: [C++][Gandiva] Re-enable Gandiva JNI tests and fix Travis CI failure #5417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you describe what was the issue? |
|
Seems like the mimalloc allocator interacts badly with the JVM in some way. |
wesm
reviewed
Sep 18, 2019
|
|
||
| if [ "$DISTRO_CODENAME" != "xenial" ]; then | ||
| CMAKE_COMMON_FLAGS="$CMAKE_COMMON_FLAGS -DARROW_MIMALLOC=ON" | ||
| fi |
There was a problem hiding this comment.
This is definitely a hack. Can you instead add an option to toggle on/off mimalloc from .travis.yml?
There was a problem hiding this comment.
updated. I'm explicitly setting ARROW_TRAVIS_MIMALLOC=1 for other jobs which also build cpp lib.
|
@pprudhvi can you add the stack from the coredump (for the mimalloc case) in the jira ? |
wesm
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.