Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-5989: [C++] Accommodate openjdk-8 path search prefix #4907

Closed
wants to merge 1 commit into from
Closed

ARROW-5989: [C++] Accommodate openjdk-8 path search prefix #4907

wants to merge 1 commit into from

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Jul 18, 2019

No description provided.

@kou
Copy link
Member

kou commented Jul 19, 2019

Could you open an issue on JIRA? https://issues.apache.org/jira/projects/ARROW/issues/
And could you use ARROW-${JIRA_ISSUE_ID}: [C++] ${SUMMARY} format for pull request title?

See also: https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches

@efiop efiop changed the title arrow: accommodate openjdk-8 path search prefix ARROW-5989: accommodate openjdk-8 path search prefix Jul 19, 2019
@efiop efiop changed the title ARROW-5989: accommodate openjdk-8 path search prefix ARROW-5989: [C++] accommodate openjdk-8 path search prefix Jul 19, 2019
@efiop
Copy link
Contributor Author

efiop commented Jul 19, 2019

Thanks for the heads up @kuo ! Created the issue and formatted the PR header. Please take a look. I also see that 2 workers failed in https://travis-ci.org/apache/arrow/builds/560726427utm_source=github_status&utm_medium=notification, but it doesn't seem to be related to my patch. Or is it?

@emkornfield
Copy link
Contributor

restarted the failed travis, jobs, I think they are unrelated as well.

@emkornfield
Copy link
Contributor

It looks like you have a lint error:
/home/travis/build/apache/arrow/cpp/src/arrow/io/hdfs-internal.cc:166: Line ends in whitespace. Consider deleting these extra spaces.

"make format" or "ninja format" should fix this.

@efiop
Copy link
Contributor Author

efiop commented Jul 20, 2019

@emkornfield Fixed formatting. Thanks for the heads up!

@efiop
Copy link
Contributor Author

efiop commented Jul 20, 2019

This time travis is passing fine, but appveyor failed ¯_(ツ)_/¯ The failure seems to be unrelated once again.

@kou kou changed the title ARROW-5989: [C++] accommodate openjdk-8 path search prefix ARROW-5989: [C++] Accommodate openjdk-8 path search prefix Jul 21, 2019
kou
kou approved these changes Jul 21, 2019
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unrelated.
I'll merge this.

@kou kou closed this in 85fe336 Jul 21, 2019
@efiop
Copy link
Contributor Author

efiop commented Jul 21, 2019 •
edited
Loading

Thank you @kou ! Sorry for bothering, but when can we expect a new release with this patch? openjdk-8 has been around for quite a while, and without this patch it is quite hard to use pyarrow on ubuntu, especially for unsuspecting users of projects that use pyarrow as a dependency.

EDIT: looks like 0.14.1 has been released a few days ago, but it is not available on pypi. Not sure if I'm asking at the right place, since the question is about pyarrow release 😕

@kou
Copy link
Member

kou commented Jul 21, 2019

0.14.1 isn't released yet. It's just RC for now.
It'll be released in a few days.

This patch will be included into the next release after 0.14.1. It'll be occurred in a few months.

You will be able to JAVA_HOME environment variable until this patch is included into our release.

@efiop
Copy link
Contributor Author

efiop commented Jul 21, 2019

@kou Maybe I could submit a backport for 0.14.1 rc so it is included into official 0.14.1?

@kou
Copy link
Member

kou commented Jul 21, 2019

It's late...
See also: https://lists.apache.org/thread.html/e343ca0aac17b00cb8edd8c48c10698cba7e244face81e5b9c065474@%3Cdev.arrow.apache.org%3E

@efiop
Copy link
Contributor Author

efiop commented Jul 21, 2019

@kou Got it. Thanks!

@efiop efiop mentioned this pull request Jul 21, 2019
Merged
2 tasks
@efiop efiop deleted the patch-1 branch July 21, 2019 15:41
kszucs pushed a commit that referenced this pull request Jul 22, 2019
@efiop @kszucs
ARROW-5989: [C++] Accommodate openjdk-8 path search prefix
ed180da 
Closes #4907 from efiop/patch-1 and squashes the following commits:

e4a2743 <Ruslan Kuprieiev> ARROW-5989:  accommodate openjdk-8 path search prefix

Authored-by: Ruslan Kuprieiev <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
pprudhvi pushed a commit to pprudhvi/arrow that referenced this pull request Aug 11, 2019
@efiop @pprudhvi
ARROW-5989: [C++] Accommodate openjdk-8 path search prefix
da5fe0e 
Closes apache#4907 from efiop/patch-1 and squashes the following commits:

e4a2743 <Ruslan Kuprieiev> ARROW-5989:  accommodate openjdk-8 path search prefix

Authored-by: Ruslan Kuprieiev <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
efiop added a commit to iterative/dvc that referenced this pull request Dec 11, 2019
@efiop
setup: update pyarrow version
6296e12 
apache/arrow#4907
@asfimport asfimport mentioned this pull request Aug 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efiop @kou @emkornfield