ARROW-5920: [Java] Support sort & compare for all variable width vectors #4860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emkornfield
reviewed
Jul 16, 2019
| if (vector instanceof TinyIntVector) { | ||
| return (VectorValueComparator<T>) new ByteComparator(); | ||
| } else if (vector instanceof SmallIntVector) { | ||
| return (VectorValueComparator<T>) new ShortComparator(); |
There was a problem hiding this comment.
Yes. It seems the Java compiler cannot infer the generic type based on the instance of operator.
Codecov Report
@@ Coverage Diff @@
## master #4860 +/- ##
==========================================
+ Coverage 87.42% 89.8% +2.38%
==========================================
Files 994 661 -333
Lines 140102 100936 -39166
Branches 1418 0 -1418
==========================================
- Hits 122481 90646 -31835
+ Misses 17259 10290 -6969
+ Partials 362 0 -362
Continue to review full report at Codecov.
|
|
+1 |
kszucs
pushed a commit
that referenced
this pull request
Jul 22, 2019
All types of variable-width vectors can reuse the same comparator for sorting & searching. Author: liyafan82 <[email protected]> Closes #4860 from liyafan82/fly_0712_varsort and squashes the following commits: cbd8c3f <liyafan82> Provide a utility to create the default comparator 46d2c11 <liyafan82> Support sort & compare for all variable width vectors
pprudhvi
pushed a commit
to pprudhvi/arrow
that referenced
this pull request
Aug 11, 2019
All types of variable-width vectors can reuse the same comparator for sorting & searching. Author: liyafan82 <[email protected]> Closes apache#4860 from liyafan82/fly_0712_varsort and squashes the following commits: cbd8c3f <liyafan82> Provide a utility to create the default comparator 46d2c11 <liyafan82> Support sort & compare for all variable width vectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All types of variable-width vectors can reuse the same comparator for sorting & searching.