ARROW-5899: [Python][Packaging] Build and link uriparser statically in Windows wheel builds #4833
Conversation
|
@ursabot crossbow submit wheel-win-cp37m |
|
|
@ursabot crossbow package wheel-win-cp37m |
|
AMD64 Conda Crossbow (#33681) builder has been succeeded. Revision: 6b87333 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-103
|
|
@ursabot crossbow package wheel-win-cp37m |
|
AMD64 Conda Crossbow (#33732) builder has been succeeded. Revision: a4ff13a Submitted crossbow builds: ursa-labs/crossbow @ ursabot-106
|
Codecov Report
@@ Coverage Diff @@
## master #4833 +/- ##
===========================================
- Coverage 82.62% 65.17% -17.45%
===========================================
Files 335 487 +152
Lines 43377 64296 +20919
Branches 1418 0 -1418
===========================================
+ Hits 35841 41907 +6066
- Misses 7174 22389 +15215
+ Partials 362 0 -362Continue to review full report at Codecov.
|
|
@ursabot crossbow package wheel-win-cp35m wheel-win-cp36m wheel-win-cp37m |
|
AMD64 Conda Crossbow (#33769) builder has been succeeded. Revision: a4ff13a Submitted crossbow builds: ursa-labs/crossbow @ ursabot-108
|
kszucs
changed the title
|
Hmm, so using |
|
@wesm Sure, but shouldn't we add uriparser's copyright notice to the LICENSE then? Also shouldn't we distribute arrow's LICENSE file with the wheels? |
|
Yes, we should. Do you know how licenses get distributed with wheels in general? |
|
Based on what we link statically additional entries are required in the LICENSE files (top level and the one under pyarrow). |
|
@ursabot crossbow package wheel-win-cp35m wheel-win-cp36m wheel-win-cp37m |
|
AMD64 Conda Crossbow (#35180) builder has been succeeded. Revision: 52616ec Submitted crossbow builds: ursa-labs/crossbow @ ursabot-118
|
|
@wesm PTAL |
wesm
changed the title
…n Windows wheel builds The windows nightly wheel builds are failing: https://ci.appveyor.com/project/Ursa-Labs/crossbow/builds/25688922 probably caused by 88fcb09, but it's hard to tell because of the error message "ImportError: DLL load failed: The specified module could not be found." is not very descriptive. Author: Krisztián Szűcs <[email protected]> Closes #4833 from kszucs/win-wheel-uriparser and squashes the following commits: 52616ec <Krisztián Szűcs> missed from the previous commit 19fca63 <Krisztián Szűcs> bundled uriparser a4ff13a <Krisztián Szűcs> cmake 6b87333 <Krisztián Szűcs> bundle uriparser.dll in windows wheels
The windows nightly wheel builds are failing: https://ci.appveyor.com/project/Ursa-Labs/crossbow/builds/25688922 probably caused by 88fcb09, but it's hard to tell because of the error message "ImportError: DLL load failed: The specified module could not be found." is not very descriptive.