ARROW-5813: [C++] Fix TensorEquals for different contiguous tensors #4774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrkn
force-pushed
the
tensor_equals_for_different_contiguous
branch
from
e1b9b9e to
e7ef17d
Compare
pitrou
requested changes
Jul 2, 2019
| @@ -155,6 +155,49 @@ TEST(TestTensor, CountNonZeroForNonContiguousTensor) { | |||
| AssertCountNonZero(t, 8); | |||
| } | |||
|
|
|||
| TEST(TestTensor, Equals) { | |||
There was a problem hiding this comment.
Is it possible to also test unequal tensors? Contiguous, non-contiguous...
There was a problem hiding this comment.
Oh, I forgot to write unequal cases.
I added them at d40c3c7
|
By the way, |
|
I filed ARROW-5830. |
Codecov Report
@@ Coverage Diff @@
## master #4774 +/- ##
==========================================
+ Coverage 86.42% 89.06% +2.64%
==========================================
Files 994 719 -275
Lines 138595 99883 -38712
Branches 1418 0 -1418
==========================================
- Hits 119776 88960 -30816
+ Misses 18457 10923 -7534
+ Partials 362 0 -362
Continue to review full report at Codecov.
|
pitrou
approved these changes
Jul 3, 2019
|
Thanks @mrkn ! Will merge. |
kou
pushed a commit
that referenced
this pull request
Jul 4, 2019
This change makes TensorEquals correctly calculate the equality of a row-major tensor and a column-major tensor. Author: Kenta Murata <[email protected]> Closes #4774 from mrkn/tensor_equals_for_different_contiguous and squashes the following commits: d40c3c7 <Kenta Murata> Add unequal expectations e7ef17d <Kenta Murata> Fix TensorEquals for different contiguous tensors
kszucs
pushed a commit
that referenced
this pull request
Jul 22, 2019
This change makes TensorEquals correctly calculate the equality of a row-major tensor and a column-major tensor. Author: Kenta Murata <[email protected]> Closes #4774 from mrkn/tensor_equals_for_different_contiguous and squashes the following commits: d40c3c7 <Kenta Murata> Add unequal expectations e7ef17d <Kenta Murata> Fix TensorEquals for different contiguous tensors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes TensorEquals correctly calculate the equality of a row-major tensor and a column-major tensor.