Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45206: [C++][CMake] Add sanitizer presets #45207

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

zanmato1984
Copy link
Contributor

@zanmato1984 zanmato1984 commented Jan 9, 2025

Rationale for this change

See #45206

What changes are included in this PR?

Add base presets for ASAN/TSAN/UBSAN. And cross product such base presets by ninja-debug which is, IMO, the config just enough necessary and likely to need sanitizers' aid.

Are these changes tested?

No need.

Are there any user-facing changes?

None.

Copy link

github-actions bot commented Jan 9, 2025

⚠️ GitHub issue #45206 has been automatically assigned in GitHub to PR creator.

@zanmato1984
Copy link
Contributor Author

Hi @kou @pitrou @mapleFU , does this make sense to you? Thanks.

@github-actions github-actions bot added the awaiting review Awaiting review label Jan 9, 2025
"inherits": "base",
"inherits": [
"base",
"sanitizer-asan",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might improve the chance to reveal issues that are hidden by jemalloc/mimalloc being enabled before.

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Jan 9, 2025
@kou kou changed the title GH-45206: [C++][CMake] Add sanitizer cmake presets GH-45206: [C++][CMake] Add sanitizer presets Jan 9, 2025
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jan 9, 2025
@zanmato1984
Copy link
Contributor Author

@github-actions crossbow submit -g cpp

Copy link

github-actions bot commented Jan 9, 2025

Revision: d575a47

Submitted crossbow builds: ursacomputing/crossbow @ actions-764caeec7d

Task Status
example-cpp-minimal-build-static GitHub Actions
example-cpp-minimal-build-static-system-dependency GitHub Actions
example-cpp-tutorial GitHub Actions
test-alpine-linux-cpp GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-cuda-cpp-ubuntu-20.04-cuda-11.2.2 GitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-fedora-39-cpp GitHub Actions
test-ubuntu-20.04-cpp GitHub Actions
test-ubuntu-20.04-cpp-bundled GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-bundled-offline GitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundled GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizer GitHub Actions

@zanmato1984
Copy link
Contributor Author

The CI failures are unrelated. Merging.

@zanmato1984 zanmato1984 merged commit f57c37a into apache:main Jan 9, 2025
38 checks passed
@zanmato1984 zanmato1984 removed the awaiting merge Awaiting merge label Jan 9, 2025
@zanmato1984 zanmato1984 deleted the add-sanitizer-cmake-presets branch January 9, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants