-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-45206: [C++][CMake] Add sanitizer presets #45207
GH-45206: [C++][CMake] Add sanitizer presets #45207
Conversation
|
"inherits": "base", | ||
"inherits": [ | ||
"base", | ||
"sanitizer-asan", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might improve the chance to reveal issues that are hidden by jemalloc/mimalloc being enabled before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@github-actions crossbow submit -g cpp |
Revision: d575a47 Submitted crossbow builds: ursacomputing/crossbow @ actions-764caeec7d |
The CI failures are unrelated. Merging. |
Rationale for this change
See #45206
What changes are included in this PR?
Add base presets for ASAN/TSAN/UBSAN. And cross product such base presets by
ninja-debug
which is, IMO, the config just enough necessary and likely to need sanitizers' aid.Are these changes tested?
No need.
Are there any user-facing changes?
None.