Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Format] Schema.fbs grammar -- replace i.e. with e.g. #45026

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

akesling
Copy link
Contributor

Rationale for this change

To improve a comment.

What changes are included in this PR?

Correction of grammar in a comment: use e.g. in a parenthetical instead of i.e.

For context: https://www.grammarly.com/blog/acronyms-abbreviations/i-e-vs-e-g/ .

Are these changes tested?

N/A

Are there any user-facing changes?

No

@github-actions github-actions bot added the awaiting review Awaiting review label Dec 13, 2024
@kou kou changed the title MINOR: Schema.fbs grammar -- replace i.e. with e.g. MINOR: [Format] Schema.fbs grammar -- replace i.e. with e.g. Dec 18, 2024
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 48e11b8 into apache:main Dec 18, 2024
9 checks passed
@kou kou removed the awaiting review Awaiting review label Dec 18, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Dec 18, 2024
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 48e11b8.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 56 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants