Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44954: [C++][CI] Silence protobuf-generated deprecations #44955

Merged
merged 8 commits into from
Dec 7, 2024

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Dec 5, 2024

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Copy link

github-actions bot commented Dec 5, 2024

⚠️ GitHub issue #44954 has been automatically assigned in GitHub to PR creator.

@pitrou pitrou force-pushed the gh44954-protobuf-deprecated branch from 682d9b3 to b914d77 Compare December 5, 2024 17:06
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Dec 6, 2024
@pitrou pitrou force-pushed the gh44954-protobuf-deprecated branch from a6b9545 to 69265ac Compare December 6, 2024 08:59
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Dec 6, 2024
@pitrou
Copy link
Member Author

pitrou commented Dec 6, 2024

@github-actions crossbow submit -g cpp

This comment was marked as outdated.

@pitrou pitrou marked this pull request as ready for review December 6, 2024 15:08
@pitrou
Copy link
Member Author

pitrou commented Dec 6, 2024

@github-actions crossbow submit -g cpp

@pitrou
Copy link
Member Author

pitrou commented Dec 6, 2024

AppVeyor failure is unrelated.

Copy link

github-actions bot commented Dec 6, 2024

Revision: 6da4538

Submitted crossbow builds: ursacomputing/crossbow @ actions-f70e902267

Task Status
example-cpp-minimal-build-static GitHub Actions
example-cpp-minimal-build-static-system-dependency GitHub Actions
example-cpp-tutorial GitHub Actions
test-alpine-linux-cpp GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-cuda-cpp-ubuntu-20.04-cuda-11.2.2 GitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-fedora-39-cpp GitHub Actions
test-ubuntu-20.04-cpp GitHub Actions
test-ubuntu-20.04-cpp-bundled GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-bundled-offline GitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundled GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizer GitHub Actions

@pitrou pitrou requested a review from assignUser December 6, 2024 15:35
@pitrou pitrou force-pushed the gh44954-protobuf-deprecated branch from 6da4538 to 87b45e3 Compare December 6, 2024 15:48
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit cf7ab12 into apache:main Dec 7, 2024
37 of 38 checks passed
@kou kou removed the awaiting change review Awaiting change review label Dec 7, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Dec 7, 2024
@pitrou pitrou deleted the gh44954-protobuf-deprecated branch December 7, 2024 10:10
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit cf7ab12.

There were 132 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants